Tracing: Make span name to be egress host_header, e.g., egress api#631
Merged
RomanDzhabarov merged 5 commits intomasterfrom Mar 27, 2017
Merged
Tracing: Make span name to be egress host_header, e.g., egress api#631RomanDzhabarov merged 5 commits intomasterfrom
RomanDzhabarov merged 5 commits intomasterfrom
Conversation
| SpanPtr HttpTracerImpl::startSpan(const Config& config, Http::HeaderMap& request_headers, | ||
| const Http::AccessLog::RequestInfo& request_info) { | ||
| std::string operation_name = config.operationName(); | ||
| if (request_headers.Host()) { |
Member
There was a problem hiding this comment.
requests must have host header.
Member
Author
There was a problem hiding this comment.
ah, right, it's checked in the same decode headers
| LocalInfo::MockLocalInfo local_info; | ||
| SystemTime time; | ||
| Http::AccessLog::MockRequestInfo request_info; | ||
| EXPECT_CALL(request_info, startTime()).WillOnce(Return(time)); |
Member
There was a problem hiding this comment.
This should be part of the default mock via ON_CALL, can you add this to default mock and clean this up elsewhere in this file.
|
|
||
| SpanPtr HttpTracerImpl::startSpan(const Config& config, Http::HeaderMap& request_headers, | ||
| const Http::AccessLog::RequestInfo& request_info) { | ||
| std::string operation_name = |
Member
There was a problem hiding this comment.
fmt::format is kind of slow. Can we just do direct string operations here.
| class HttpTracerImplTest : public Test { | ||
| public: | ||
| HttpTracerImplTest() { | ||
| ON_CALL(request_info_, startTime()).WillByDefault(Return(start_time_)); |
Member
There was a problem hiding this comment.
This should go directly in the request_info_ mock. It doesn't need to be here.
test/mocks/tracing/mocks.h
Outdated
|
|
||
| MOCK_CONST_METHOD0(operationName, const std::string&()); | ||
|
|
||
| const std::string operation_name_ = "operation"; |
Member
There was a problem hiding this comment.
Someone might want to change this. I would make this non-const.
mattklein123
approved these changes
Mar 27, 2017
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
Signed-off-by: wujie1993 <qq594jj@gmail.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: updating the envoy ref again and the absolute binary size per #447. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: updating the envoy ref again and the absolute binary size per #447. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Capabilities docs explaining upstream auth, its purpose, and what it does conceptually. This is to help highlight a key capability of the Envoy AI Gateway that is easy to overlook. --------- Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lyft/network-team