Merged
Conversation
Slight refactor to allow setup scripts to be also called from private code.
Member
Author
|
@htuch we need this to get our private tests working. I think this should be OK. |
Member
|
LGTM.
…On Sat, Mar 25, 2017 at 1:09 PM Matt Klein ***@***.***> wrote:
@htuch <https://github.com/htuch> we need this to get our private tests
working. I think this should be OK.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#627 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKaLvwtNjUdQ-MR-cTRF-9L0o4H8G6LZks5rpUpcgaJpZM4MpJEq>
.
|
Member
|
Actually, can you push the mkdir to the scripts themselves, since I'll be
only invoking them from Bazel.
…On Sat, Mar 25, 2017 at 1:34 PM Harvey Tuch ***@***.***> wrote:
LGTM.
On Sat, Mar 25, 2017 at 1:09 PM Matt Klein ***@***.***>
wrote:
@htuch <https://github.com/htuch> we need this to get our private tests
working. I think this should be OK.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#627 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKaLvwtNjUdQ-MR-cTRF-9L0o4H8G6LZks5rpUpcgaJpZM4MpJEq>
.
|
Member
Author
|
@htuch updated |
Member
|
LGTM |
jplevyak
added a commit
to jplevyak/envoy
that referenced
this pull request
Sep 15, 2020
Test nack on load failure on SHA mismatch as well.
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Jan 18, 2023
…oyproxy#651) * build(deps): bump setuptools from 59.0.1 to 59.5.0 in /tools/base (envoyproxy#606) Bumps [setuptools](https://github.com/pypa/setuptools) from 59.0.1 to 59.5.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v59.0.1...v59.5.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump setuptools from 59.5.0 to 60.1.0 in /tools/base (envoyproxy#620) Bumps [setuptools](https://github.com/pypa/setuptools) from 59.5.0 to 60.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v59.5.0...v60.1.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add support for validating header keys and values fixes envoyproxy#627 Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * address PR feedback Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add quic header key/value validation Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add runtime guard: envoy.reloadable_features.validate_upstream_headers Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * honor runtime guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * update integration tests for invalid header key/value validation Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix http/2 integration tests for invalid header values Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * use nghttp2 for header name and value rfc compliance checks Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * bypass assertions to set invalid header key/value for protocol integration tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix bad merge on changelog Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit invalid header integration tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * add entry for new envoy.reloadable_features.validate_upstream_headers runtime guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * clarify validate_upstream_headers guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * disable validate_upstream_headers guard Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix build Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit tests Signed-off-by: Adam Meily <adam.meily@trailofbits.com> * fix unit test Signed-off-by: Adam Meily <adam.meily@trailofbits.com> Signed-off-by: Adam Meily <adam.meily@trailofbits.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Fix typo for endpoint filter metadata from aigateawy to aigateway Signed-off-by: Dan Sun <dsun20@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight refactor to allow setup scripts to be also called from private
code.