config: implement incremental CDS in Envoy#6191
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
|
|
||
| rpc IncrementalRoutes(stream IncrementalDiscoveryRequest) | ||
| returns (stream IncrementalDiscoveryResponse) { | ||
| rpc DeltaRoutes(stream DeltaDiscoveryRequest) returns (stream DeltaDiscoveryResponse) { |
There was a problem hiding this comment.
This method name change is not wire compatible (it changes the URL), thus is against Breaking change policy.
There was a problem hiding this comment.
I'd have to hear from a more experienced Envoy person to be sure, but I think this one is an exception because we are sure that both sides of this gRPC service are completely unimplemented until now.
There was a problem hiding this comment.
Yes, incremental xDS is entirely experimental, so this is legit.
There was a problem hiding this comment.
Is this indicated in the proto file somewhere, or is there some other way we should be able to know what is experimental and what is considered "frozen"?
There was a problem hiding this comment.
In this specific case, it's well known in the Envoy/xDS community that this feature is highly experimental; there is no client or server in the wild that implement this as it's a moving target. You can track this work at #4991.
Signed-off-by: Fred Douglas fredlas@google.com
Description: Code for Envoy to speak delta CDS with a management server. DELTA_GRPC added to config_source.proto's ApiTypes, to allow bootstrap configs to ask for incremental xDS.
Part of #4991. Was #5466; giving up on broken DCO craziness.
Risk Level: medium
Testing: new integration test