udp: implement recvfrom(2) in os_sys_calls_impl#6160
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Mar 5, 2019
Merged
udp: implement recvfrom(2) in os_sys_calls_impl#6160alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Member
Author
|
/assign @alyssawilk @conqerAtapple |
Contributor
|
LGTM. |
alyssawilk
approved these changes
Mar 5, 2019
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Thanks for following up on this!
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Description: implement recvfrom(2) in os_sys_calls and use in udp_listener_impl Risk Level: Low - same functionality but different implementation Testing: bazel test //test/common/network:udp_listener_impl_test Docs Changes: N/A Release Notes: N/A Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com
Description: implement recvfrom(2) in os_sys_calls and use in udp_listener_impl
Risk Level: Low - same functionality but different implementation
Testing:
bazel test //test/common/network:udp_listener_impl_testDocs Changes: N/A
Release Notes: N/A