Extension: update gRPC HTTP/1.1 Reverse Bridge extension documentation & code layout#6158
Merged
mattklein123 merged 8 commits intoenvoyproxy:masterfrom Mar 5, 2019
moderation:master
Merged
Extension: update gRPC HTTP/1.1 Reverse Bridge extension documentation & code layout#6158mattklein123 merged 8 commits intoenvoyproxy:masterfrom moderation:master
mattklein123 merged 8 commits intoenvoyproxy:masterfrom
moderation:master
Conversation
Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: Michael Payne <michael@sooper.org>
…erse Bridge extension. Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: Michael Payne <michael@sooper.org>
snowp
approved these changes
Mar 4, 2019
Contributor
snowp
left a comment
There was a problem hiding this comment.
Thanks, this LGTM. Mind updating the description/title to reflect the fact that you're modifying more than just the reverse bridge documentation?
Contributor
Author
|
@snowp done. |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…n & code layout (envoyproxy#6158) Signed-off-by: Michael Payne <michael@sooper.org> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Extension: update gRPC HTTP/1.1 Reverse Bridge extension documentation & code layout
Risk Level: Low. There is a small change to the extension code for consistency with the rest of the code base. This extension was the only one using
envoy.extensions.andenvoy::extensions::vsenvoy.config.andenvoy::config::. Otherwise this is documentation only.Testing:
bazel test //test/...and a bunch of document generation testing.Docs Changes: this PR
Release Notes: none required
[Fixes #Issue] #6154
/cc @snowp for review