Skip to content

Limit error spew from compiler.#607

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
htuch:error-limit
Mar 22, 2017
Merged

Limit error spew from compiler.#607
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
htuch:error-limit

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Mar 22, 2017

It's a pain scrolling up through pages of errors (e.g. when mocks are messed up) to find the first
error in a terminal, there's diminishing returns past the first few error messages.

It's a pain scrolling up through pages of errors (e.g. when mocks are messed up) to find the first
error in a terminal, there's diminishing returns past the first few error messages.
@mattklein123
Copy link
Copy Markdown
Member

Can we make this opt-in potentially via a cmake/bazel variable of some type? I would like to try this out for a while before doing it universally.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 22, 2017

I'll make it opt-in for cmake and leave it as default for Bazel, since I'm the only one affected by that right now.

@mattklein123 mattklein123 merged commit 356fd05 into envoyproxy:master Mar 22, 2017
@htuch htuch deleted the error-limit branch March 31, 2017 16:30
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Use mixer client of using protobuf Attributes.

* Change to use raw pointer for AttributesBuilder

* Not to use concated .Add calls()

* Update to mixer client sha.
jplevyak added a commit to jplevyak/envoy that referenced this pull request Aug 10, 2020
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: turn on tsan and asan runs for core tests.
Risk Level: low
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: turn on tsan and asan runs for core tests.
Risk Level: low
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**

This fixes `aigw run` command which has been disabled since the
refactoring in #599. This requires a couple bug fixes in Envoy Gateway
side, so this commit includes the upgrade of the EG as a dependency.

**Related Issues/PRs (if applicable)**

* Closes #607
* Includes envoyproxy/gateway/pull/5984
* Includes envoyproxy/gateway/pull/6020

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants