build: bump libevent to c4fbae3a.#6062
Merged
htuch merged 11 commits intoenvoyproxy:masterfrom Mar 5, 2019
Merged
Conversation
…oxy#6042. Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
Tagging libevent/libevent#778 |
azat
added a commit
to libevent/libevent
that referenced
this pull request
Mar 3, 2019
In case we have empty chain (chain that do not have any data, i.e. ->off == 0) at the beginning of the buffer, and no more full chains to move to the dst, we will skip moving of this empty chain, and hence last_with_datap will not be adjusted, and things will be broken after. Fix this by not relying on ->off, just count if we have something to move that's it. Test case from: envoyproxy/envoy#6062 Fixes: #774
azat
added a commit
to libevent/libevent
that referenced
this pull request
Mar 3, 2019
advance_last_with_data() adjusts evbuffer.last_with_datap, and if we will have empty chain in the middle advance_last_with_data() will stop, while it should not, since while empty chains is not regular thing they can pops up in various places like, and while I did not look through all of them the most tricky I would say is: evbuffer_reverse_space()/evbuffer_commit_space() evbuffer_add_reference() Test case from: envoyproxy/envoy#6062 Fixes: #778 v2: keep last_with_datap really last with data, i.e. update only if chain has data in it
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
reviewed
Mar 4, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
approved these changes
Mar 5, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
This brings in buffer correctness fixes for libevent/libevent#774 and libevent/libevent#778. This will temporarily take us away from a released version until 2.1.9. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13400. Risk level: Low (since we're already at 2.1.9-beta, which is pretty near in history). Testing: regression unit tests added upstream in libevent, corpus entry added. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in buffer correctness fixes for libevent/libevent#774 and libevent/libevent#778.
This will temporarily take us away from a released version until 2.1.9.
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13400.
Risk level: Low (since we're already at 2.1.9-beta, which is pretty near in history).
Testing: regression unit tests added upstream in libevent, corpus entry added.
Signed-off-by: Harvey Tuch htuch@google.com