fuzz: basic buffer implementation fuzzer.#5996
Merged
htuch merged 12 commits intoenvoyproxy:masterfrom Feb 21, 2019
Merged
Conversation
Basic trace fuzzer for the Buffer interface operations. Verifies some basic properties and compares with a shadow buffer linearize after each operation. Intended to support validation of envoyproxy#5441. Risk level: Low Testing: Simple manal corpus that provides 95.1% coverage of buffer_impl.cc. Will expand in future PRs. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
brian-pane
reviewed
Feb 19, 2019
Contributor
brian-pane
left a comment
There was a problem hiding this comment.
Thanks for writing this! I just read through the code and added some comments and questions.
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
brian-pane
previously approved these changes
Feb 20, 2019
Contributor
brian-pane
left a comment
There was a problem hiding this comment.
With the latest changes, this LGTM.
Member
mattklein123
left a comment
There was a problem hiding this comment.
Very cool, thanks for working on this, it will give me a lot more confidence in the new buffer implementation. Some small comments/questions.
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Feb 21, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Basic trace fuzzer for the Buffer interface operations. Verifies some basic properties and compares with a shadow buffer based on std::string. Intended to support validation of envoyproxy#5441. Risk level: Low Testing: Simple manual corpus that provides 95.1% coverage of buffer_impl.cc. Will expand in future PRs. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic trace fuzzer for the Buffer interface operations. Verifies some
basic properties and compares with a shadow buffer based on std::string. Intended to support validation of
#5441.
Risk level: Low
Testing: Simple manual corpus that provides 95.1% coverage of
buffer_impl.cc. Will expand in future PRs.
Signed-off-by: Harvey Tuch htuch@google.com