test: Fix all tests that were failing the test-base assert due to multi-inheritance order.#5855
Merged
jmarantz merged 3 commits intoenvoyproxy:masterfrom Feb 6, 2019
Merged
Conversation
…eritance order. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
|
@jmarantz can you merge master? |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
Yup, merging master erased my change to test/fuzz/main.cc. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…eritance order. (envoyproxy#5855) Signed-off-by: Joshua Marantz <jmarantz@google.com> Previously the TestBase destructor was running the singleton quiescence check and printing the results, but not actually failing the tests.. There are two changes here: * use a RELEASE_ASSERT in the quiescence check helper function, rather than returning a bool * change a bunch of tests that multiply inherited from the TestBase class to always specify the TestBase class first. Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Previously the TestBase destructor was running the singleton quiescence check and printing the results, but not actually failing the tests..
There are two changes here:
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a