add assertion for null/reset connection file event#5848
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 6, 2019
bdecoste:connection_file_event_assert
Merged
add assertion for null/reset connection file event#5848mattklein123 merged 1 commit intoenvoyproxy:masterfrom bdecoste:connection_file_event_assert
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
bdecoste:connection_file_event_assert
Conversation
Signed-off-by: William DeCoste <bdecoste@gmail.com>
htuch
approved these changes
Feb 5, 2019
Contributor
Author
|
Thank you |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: William DeCoste <bdecoste@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: William DeCoste bdecoste@gmail.com
Description: Add assertion to catch unexpected null file_event_ when connection is closed for openssl TLS_1.2 with Server RSA/ECDSA and Client ECDSA.
Risk Level: Low
Testing: All standard tests pass
Docs Changes: None
Release Notes: None