Skip to content

ci: fix OS X CI issues.#5827

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:fix-os-x
Feb 4, 2019
Merged

ci: fix OS X CI issues.#5827
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:fix-os-x

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Feb 4, 2019

E.g. from https://circleci.com/gh/envoyproxy/envoy/159452?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

we're seeing:

Error: No available formula with the name "bazelbuild/tap/bazel"
Please tap it and then try again: brew tap bazelbuild/tap

Looks like some additional steps are needed for the brew tap based on
https://docs.bazel.build/versions/master/install-os-x.html.

Risk Level: Low
Testing: CI

Fixes #5830

Signed-off-by: Harvey Tuch htuch@google.com

E.g. from https://circleci.com/gh/envoyproxy/envoy/159452?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

we're seeing:

Error: No available formula with the name "bazelbuild/tap/bazel"
Please tap it and then try again: brew tap bazelbuild/tap

Looks like some additional steps are needed for the brew tap based on
https://docs.bazel.build/versions/master/install-os-x.html.

Risk Level: Low
Testing: CI

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from zuercher February 4, 2019 15:41
@htuch htuch mentioned this pull request Feb 4, 2019
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Feb 4, 2019

The Mac build seemed to flake on some unrelated test, so going to force merge to unblock other PRs.

@htuch htuch merged commit 5b9912d into envoyproxy:master Feb 4, 2019
@htuch htuch deleted the fix-os-x branch February 4, 2019 20:40
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
E.g. from https://circleci.com/gh/envoyproxy/envoy/159452?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

we're seeing:

Error: No available formula with the name "bazelbuild/tap/bazel"
Please tap it and then try again: brew tap bazelbuild/tap

Looks like some additional steps are needed for the brew tap based on
https://docs.bazel.build/versions/master/install-os-x.html.

Risk Level: Low
Testing: CI

Fixes envoyproxy#5830

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants