added example for delay fault injection#5816
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Feb 4, 2019
Merged
Conversation
Signed-off-by: Kim Saabye Pedersen <k.epost@gmail.com>
c39cf7b to
5edf3e4
Compare
snowp
suggested changes
Feb 2, 2019
Contributor
snowp
left a comment
There was a problem hiding this comment.
Left a comment on the language, but otherwise LGTM.
Thanks for adding another example!
examples/fault-injection/README.md
Outdated
| bash enable_delay_fault_injection.sh | ||
| ``` | ||
|
|
||
| The script above enables HTTP 3.000 ms delays for 50% of the requests. So, you should now see a continuous sequence of HTTP 200 |
Contributor
There was a problem hiding this comment.
Maybe something like The script above will add a 3 second delay to 50% of HTTP requests? I know you matched the phrasing for aborts, but I think it might flow better
Aslo, English uses commas for thousands separators, so you'd want to use 3,000 (instead of 3.000) if you're talking in terms of milliseconds.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. I have changed the wording.
Contributor
|
You'll need to fix up DCO on the last commit, see https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#fixing-dco |
Signed-off-by: Kim Saabye Pedersen <k.epost@gmail.com>
8a59711 to
8f8f023
Compare
Contributor
Author
|
DCO has been fixed, thanks for the feedback. |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Kim Saabye Pedersen <k.epost@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Added a new example of fault injection: delay fault injection
Risk Level: Low
Testing: Manually tested
Docs Changes: changed the readme in the example
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]