Make Envoy::Server::Options argument to Envoy::Server::InstanceImpl const#5793
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Feb 7, 2019
Merged
Conversation
added 2 commits
January 24, 2019 14:56
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
added 2 commits
January 31, 2019 14:31
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
added 2 commits
February 5, 2019 14:19
Signed-off-by: Randy Smith <rdsmith@google.com>
Signed-off-by: Randy Smith <rdsmith@google.com>
Contributor
Author
|
/assign curiouserrandy |
Signed-off-by: Randy Smith <rdsmith@google.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…onst (envoyproxy#5793) Signed-off-by: Randy Smith <rdsmith@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Make Envoy::Server::Options argument to Envoy::Server::InstanceImpl const
Risk Level: Low: Just altering argument qualifiers. Problems would show in compilation.
Testing: Existing tests.
Docs Changes: None.
Fixes #5792