Decouple common_ssl from common_secret#5524
Closed
bdecoste wants to merge 1 commit intoenvoyproxy:masterfrom
bdecoste:common_secret
Closed
Decouple common_ssl from common_secret#5524bdecoste wants to merge 1 commit intoenvoyproxy:masterfrom bdecoste:common_secret
bdecoste wants to merge 1 commit intoenvoyproxy:masterfrom
bdecoste:common_secret
Conversation
Signed-off-by: William DeCoste <bdecoste@gmail.com>
lizan
suggested changes
Jan 7, 2019
Member
lizan
left a comment
There was a problem hiding this comment.
@bdecoste The goal is to make we can compile without BoringSSL. How about do the opposite by moving BoringSSL dependent part to source/extensions/transport_sockets/ssl and keep common/ssl with common TLS config stuff? I know there will be more code to be moved, though it will be clearer that the BoringSSL is as an extension and easier to spot the code pulls in BoringSSL. WDYT?
Contributor
Author
|
OK, that makes sense. I was trying to minimize the code impact to isolate the boringssl. I'll close this PR and move all of the boringssl dependent code to extensions. That fits with what I've done locally for openssl since I've created source/extensions/transport_sockets/openssl |
lizan
pushed a commit
that referenced
this pull request
Jan 16, 2019
*Description*: As part of the work to support openssl this PR moves all boringssl dependencies to extensions. This is one step that will enable the linking and testing of openssl with a new transport socket for openssl. Those files with boringssl dependencies were moved from common/ssl to extensions/transport_sockets/ssl with similar changes for the tests. Please see #5524 for additional context. *Risk Level*: Low *Testing*: Standard tests passed *Docs Changes*: None *Release Notes*: None Signed-off-by: William DeCoste <bdecoste@gmail.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
*Description*: As part of the work to support openssl this PR moves all boringssl dependencies to extensions. This is one step that will enable the linking and testing of openssl with a new transport socket for openssl. Those files with boringssl dependencies were moved from common/ssl to extensions/transport_sockets/ssl with similar changes for the tests. Please see envoyproxy#5524 for additional context. *Risk Level*: Low *Testing*: Standard tests passed *Docs Changes*: None *Release Notes*: None Signed-off-by: William DeCoste <bdecoste@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: William DeCoste bdecoste@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: As part of the work to support openssl this PR decouples the dependency of common/secret on common/ssl. This is one step that will enable the linking and testing of openssl with a new transport socket for openssl. The common/secret package did not require the common/ssl components that depended on the ssl libraries. The classes required by common/secret were moved into a new common/certificate package.
Risk Level: Low
Testing: Standard tests passed
Docs Changes: None
Release Notes: None
[Optional Fixes #Issue]
[Optional Deprecated:]