Outlier detection config#543
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Mar 9, 2017
Merged
Conversation
Member
|
needs docs |
ccaraman
reviewed
Mar 7, 2017
Contributor
There was a problem hiding this comment.
move these to the initializer list
mattklein123
reviewed
Mar 7, 2017
Member
There was a problem hiding this comment.
don't "allow_empty" here (remove true param), the object must exist in this branch.
Member
There was a problem hiding this comment.
this is not really a useful test. Can you test the config object directly, and make sure the loaded values are what you expect (or do that additionally)
45fb071 to
f15d8ae
Compare
ccaraman
reviewed
Mar 7, 2017
Contributor
There was a problem hiding this comment.
{} is no longer needed since you are using the initializer list.
mattklein123
reviewed
Mar 9, 2017
Member
There was a problem hiding this comment.
nit: pass const Json::Object&
Member
There was a problem hiding this comment.
nit: pass const Json::Object&
Member
There was a problem hiding this comment.
nit: pass const Json::Object&
Member
There was a problem hiding this comment.
nit: you don't need false param, it's the default.
619f65e to
97209f3
Compare
mattklein123
approved these changes
Mar 9, 2017
jplevyak
pushed a commit
to istio/envoy
that referenced
this pull request
Jul 9, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: this PR integrates [Envoy's ApiListener](#9516) to replace Envoy Mobile's use of the AsyncClient. Doing so gives Envoy Mobile access to all L7 facilities provided by Envoy's Http Connection Manager; including but no limited to the L7 filters. Risk Level: HIGH! This PR changes the underlying code for Envoy Mobile's core functionality Testing: unit tests updated for the dispatcher, integration tests, and e2e tests with the example apps. Additionally, the ApiListener code has been unit and integration tested in Envoy. Fixes #543 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: this PR integrates [Envoy's ApiListener](#9516) to replace Envoy Mobile's use of the AsyncClient. Doing so gives Envoy Mobile access to all L7 facilities provided by Envoy's Http Connection Manager; including but no limited to the L7 filters. Risk Level: HIGH! This PR changes the underlying code for Envoy Mobile's core functionality Testing: unit tests updated for the dispatcher, integration tests, and e2e tests with the example apps. Additionally, the ApiListener code has been unit and integration tested in Envoy. Fixes #543 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #540