Skip to content

tls: split client/server defaults.#5392

Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom
PiotrSikora:tls_client_server_defaults
Jan 2, 2019
Merged

tls: split client/server defaults.#5392
ggreenway merged 1 commit intoenvoyproxy:masterfrom
PiotrSikora:tls_client_server_defaults

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

No functional changes.

Signed-off-by: Piotr Sikora piotrsikora@google.com

No functional changes.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

cc @ggreenway @lizan

@PiotrSikora PiotrSikora force-pushed the tls_client_server_defaults branch from 3438c44 to d81fc73 Compare December 22, 2018 00:42
@lizan
Copy link
Copy Markdown
Member

lizan commented Dec 22, 2018

@PiotrSikora code LGTM, though why this is needed? Will there be divergence between client and server in future?

@lizan lizan self-assigned this Dec 22, 2018
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Yes, see #5401.

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

cc @ggreenway @mattklein123

@ggreenway ggreenway merged commit 58bf369 into envoyproxy:master Jan 2, 2019
@PiotrSikora PiotrSikora mentioned this pull request Jan 3, 2019
11 tasks
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
No functional changes.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants