Update all unattributed TODOs to TODO(mattklein123) by tschroed · Pull Request #529 · envoyproxy/envoy

tschroed · 2017-03-03T17:04:12Z

Quoting the style guide:

TODOs should include the string TODO in all caps, followed by the username or b/buganizer_id of the person or issue with the best context about the problem referenced by the TODO. The main purpose is to have a consistent TODO that can be searched to find out how to get more details upon request. A TODO is not a commitment that the person referenced will fix the problem. Thus when you create a TODO with a name, it is almost always your name that is given.

mattklein123 · 2017-03-03T17:09:52Z

Though as I said in gitter, this information is available more accurately via "git blame", if you want to do this let's use accurate GH user names, so it would be "mattklein123".

tschroed · 2017-03-03T17:21:53Z

I'm lazy and shelling out and waiting for blame harshes my mojo.

Plus this is refactor proof so you don't get blamed just because you moved some lines around.

mattklein123

some typos and you need to run clang-format

mattklein123 · 2017-03-03T18:42:08Z

source/common/filter/tcp_proxy.cc

-    //       is about to go away. So to support this we need to either have a way for the downstream
-    //       connection to stick around, or, we need to be able to pass this connection to a flush
-    //       worker which will attempt to flush the remaining data with a timeout.
+    // TODO(mklein23): If we close without flushing here we may drop some data. The downstream


typo, mattklein123

mattklein123 · 2017-03-03T18:42:33Z

source/common/http/conn_manager_impl.cc

-  // TODO: If a filter returns StopIterationNoBuffer and then does a continue, we won't be able to
-  //       end the stream if there is no buffered data. Need to handle this.
+  // TODO(mattklein123): If a filter returns StopIterationNoBuffer and then does a continue, we
+  // won't be able to  end the stream if there is no buffered data. Need to handle this.


typo extra space

mattklein123 · 2017-03-03T18:42:52Z

source/common/filter/tcp_proxy.cc

+    // TODO(mklein23): If we close without flushing here we may drop some data. The downstream
+    // connection  is about to go away. So to support this we need to either have a way for the
+    // downstream  connection to stick around, or, we need to be able to pass this connection to a
+    // flush  worker which will attempt to flush the remaining data with a timeout.


typo extra space

mattklein123 · 2017-03-03T18:43:26Z

source/common/http/header_map_impl.cc

-    //       it should be appended to. In that case, we would do an append here. We can do this in
-    //       a follow up.
+    // TODO(mattklein123): Currently, for all of the inline headers, we don't support appending. The
+    // only inline  header where we should be converting multiple headers into a comma delimited


typo extra space here and below

tschroed · 2017-03-03T19:45:39Z

I'm bumbling my way through remembering the github workflow. Sorry you're on the receiving end.

RomanDzhabarov · 2017-03-03T20:20:03Z

source/common/filter/tcp_proxy.cc

-    // connection  is about to go away. So to support this we need to either have a way for the
-    // downstream  connection to stick around, or, we need to be able to pass this connection to a
-    // flush  worker which will attempt to flush the remaining data with a timeout.
+    // TODO(mattklein23): If we close without flushing here we may drop some data. The downstream


mattklein123

…ning it.

mattklein123 · 2017-03-03T21:27:10Z

source/common/filter/tcp_proxy.cc

-    //       is about to go away. So to support this we need to either have a way for the downstream
-    //       connection to stick around, or, we need to be able to pass this connection to a flush
-    //       worker which will attempt to flush the remaining data with a timeout.
+    // TODO(mattklein23): If we close without flushing here we may drop some data. The downstream


mattklein23 -> mattklein123

mattklein123 · 2017-03-03T21:28:17Z

test/integration/integration_test.cc

-       [&]() -> void { fake_upstream_connection->waitForData(10); },
-       [&]() -> void { fake_upstream_connection->waitForDisconnect(); }});
-}
+== network/connection_impl.cc ==


You probably already saw this, but FYI some editor issue here.

I just saw this. I have no idea what happened because I ran the CI before pushing but apparently totally scrambled the file between step 1 and 2. Sigh.

mattklein123 · 2017-03-04T00:23:01Z

@tschroed there is still one typo then looks good.

mattklein123 · 2017-03-04T03:26:25Z

@tschroed also please sign the CLA: https://github.com/lyft/envoy/blob/master/CONTRIBUTING.md#cla

tschroed · 2017-03-04T04:32:55Z

CLA signed. Typo corrected. Thanks for your infinite patience. Next time will be smoother, promise.

* Add 'fail_open' configuration option for Wasm plugins. Signed-off-by: John Plevyak <jplevyak@gmail.com>

…oxy#529)

Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>

**Commit Message** Fix APISchema to support response_format. **Related Issues/PRs (if applicable)** Related PR: #445 --------- Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>

Update all unattributed TODOs to TODO(mklein123).

615d4f7

s/mklein123/mattklein123/

b0e5499

mattklein123 reviewed Mar 3, 2017

View reviewed changes

mattklein123 changed the title ~~Update all unattributed TODOs to TODO(mklein123).~~ Update all unattributed TODOs to TODO(mattklein123) Mar 3, 2017

Trevor Schroeder added 2 commits March 3, 2017 14:26

Format with the appropriate clang-format config.

cb9f76c

Correct typos.

312c43a

RomanDzhabarov reviewed Mar 3, 2017

View reviewed changes

check_format is more strict than clang-format in the way that I'm run…

b41c903

…ning it.

mattklein123 reviewed Mar 3, 2017

View reviewed changes

De-scramble the integration test. ci/do_ci.sh passes.

9c41931

mattklein123, not mattklein23.

0b268f1

mattklein123 approved these changes Mar 4, 2017

View reviewed changes

mattklein123 merged commit 51b5871 into envoyproxy:master Mar 4, 2017

tschroed deleted the TODO-attribution branch March 7, 2017 14:42

tschroed added a commit to tschroed/envoy that referenced this pull request Apr 10, 2017

Update all unattributed TODOs to TODO(mattklein123) (envoyproxy#529)

5a301ee

lizan pushed a commit to lizan/envoy that referenced this pull request Jun 4, 2020

Wasm proto failopen (envoyproxy#529)

50902ab

* Add 'fail_open' configuration option for Wasm plugins. Signed-off-by: John Plevyak <jplevyak@gmail.com>

wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021

zh-translation:docs/root/version_history/version_history.rst (envoypr…

e91bdc9

…oxy#529)

jpsim pushed a commit that referenced this pull request Nov 28, 2022

docs: update outdated example documentation (#529)

63f31c0

Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>

jpsim pushed a commit that referenced this pull request Nov 29, 2022

docs: update outdated example documentation (#529)

634f3b6

Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>

Conversation

tschroed commented Mar 3, 2017

Uh oh!

mattklein123 commented Mar 3, 2017

Uh oh!

tschroed commented Mar 3, 2017

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tschroed commented Mar 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattklein123 commented Mar 4, 2017

Uh oh!

mattklein123 commented Mar 4, 2017

Uh oh!

tschroed commented Mar 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants