reformat dynamic metadata emitted by Mongo proxy#5117
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Nov 27, 2018
Merged
reformat dynamic metadata emitted by Mongo proxy#5117mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
|
|
||
| operation, string, The operation to be executed. | ||
| resource, string, The resource name in *db.collection* format on which the operation is to be executed. | ||
| <db.collection>, string, The resource name in *db.collection* format. |
Member
There was a problem hiding this comment.
Suggested change
| <db.collection>, string, The resource name in *db.collection* format. | |
| key, string, The resource name in *db.collection* format. |
| operation, string, The operation to be executed. | ||
| resource, string, The resource name in *db.collection* format on which the operation is to be executed. | ||
| <db.collection>, string, The resource name in *db.collection* format. | ||
| [], list, A list of strings, representing the operations executed on the resource. Operation is either insert,update,query,delete. |
Member
There was a problem hiding this comment.
Suggested change
| [], list, A list of strings, representing the operations executed on the resource. Operation is either insert,update,query,delete. | |
| value, array, A list of strings representing the operations executed on the resource. |
The docs job doesn't like too many commas in a table. A backslash escape may work.
| EXPECT_TRUE(nullptr != metadata.fields().at("db.test1")); | ||
| EXPECT_EQ("query", metadata.fields().at("db.test1").list_value().values(0).string_value()); | ||
| EXPECT_TRUE(nullptr != metadata.fields().at("db.test2")); | ||
| EXPECT_EQ("insert", metadata.fields().at("db.test1").list_value().values(0).string_value()); |
added 2 commits
November 26, 2018 17:45
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
dio
suggested changes
Nov 26, 2018
Member
dio
left a comment
There was a problem hiding this comment.
Looks good. But I think adding a version history entry will be helpful.
|
|
||
| message[DynamicMetadataKeysSingleton::get().OperationField].set_string_value(operation); | ||
| message[DynamicMetadataKeysSingleton::get().ResourceField].set_string_value(resource); | ||
| // TODO(rshriram): reverse the resource string (table.db) |
Member
There was a problem hiding this comment.
Super nit, add period at the end of the sentence (and also the other TODOs/comments).
Member
Author
|
@dio the PR that implemented this was merged yesterday :). So users have not seen this stuff yet. So version history doesn't exist.. |
dio
approved these changes
Nov 26, 2018
Member
dio
left a comment
There was a problem hiding this comment.
Sorry about that.
Thank you! LGTM!
mattklein123
approved these changes
Nov 27, 2018
| operation, string, The operation to be executed. | ||
| resource, string, The resource name in *db.collection* format on which the operation is to be executed. | ||
| key, string, The resource name in *db.collection* format. | ||
| value, array, A list of strings representing the operations executed on the resource (insert/update/query/delete). |
Member
There was a problem hiding this comment.
Per our offline convo, FYI, in order for this to be actually useful you are going to have to log/store query commands.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Emit metadata as
map<resource, list(operations>so that it can be used in metadata matchers easily. The existing format (messages:list(structs)) is too hard to represent in metadata matchers.Risk Level: LOW
Testing: Unit tests
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com
cc @venilnoronha