Conversation
|
@lyft/network-team @rshriram @timperrett @GregHanson would appreciate feedback on whether this is sufficient or you want more detail. |
| -------- | ||
|
|
||
| The :ref:`service discovery service (SDS) API <config_cluster_manager_sds>` provides a more advanced | ||
| mechanism by which Envoy can discovery members of an upstream cluster. Layered on top of a static |
| which Envoy can discover upstream clusters used during routing. Envoy will gracefully add, update, | ||
| and remove clusters as specified by the API. This API allows implementors to build a topology in | ||
| which Envoy does not need to be aware of all upstream clusters at initial configuration time. | ||
| Typically, when doing HTTP routing along with CDS (but without RDS), implementors will make use of |
There was a problem hiding this comment.
but without route discovery service, RDS. First time mentioned here.
| SDS, CDS, and RDS | ||
| ----------------- | ||
|
|
||
| The :ref:`route discovery service API <config_http_conn_man_rds>` layers on a mechanism by which |
There was a problem hiding this comment.
(RDS) again, because this is the main section about it?
|
|
||
| The :ref:`route discovery service API <config_http_conn_man_rds>` layers on a mechanism by which | ||
| Envoy can discover the entire route configuration for an HTTP connection manager filter at runtime. | ||
| The route configuration will be gracefully swapped in without effecting existing requests. This API, |
junr03
left a comment
There was a problem hiding this comment.
looks complete to me. Just a couple comments.
|
@mattklein123 as an introduction, I think this is fine - it sets the stage that these things are possible with Envoy. The biggest gap from an implementing users perspective is complete examples - it took me a while and several false guesses to get the config right. I want to say these should be on the docs site; i'm aware of the examples folder in the source - that was useful - but im fairly sure most people will not look at the source code (for better or worse). |
|
@timperrett let me at least link to the examples in the source tree from the docs for now. I agree we can do better with more examples in the docs. |
|
updated |
| The :ref:`service discovery service (SDS) API <config_cluster_manager_sds>` provides a more advanced | ||
| mechanism by which Envoy can discover members of an upstream cluster. Layered on top of a static | ||
| configuration, SDS allows an Envoy deployment to circumvent the limitations of DNS (maximum records | ||
| in a response, etc.) as well as consume more information used in load balancing and routing (e.g., |
There was a problem hiding this comment.
nit: as we do not support canary routing yet, i'd just mention weight, zone, etc.
There was a problem hiding this comment.
we use it for generating stats.
There was a problem hiding this comment.
that's fine, although arguably it's used in balancing and routing
|
lgtm |
Add Wasm code cache and option to fail if not cached.
…ilter.rst (envoyproxy#489) * fix translation issue * Update docs/root/configuration/http/http_filters/ip_tagging_filter.rst Co-authored-by: Addo.Zhang <duwasai@gmail.com> * Update docs/root/configuration/http/http_filters/ip_tagging_filter.rst Co-authored-by: Addo.Zhang <duwasai@gmail.com> * Update docs/root/configuration/http/http_filters/ip_tagging_filter.rst Co-authored-by: Addo.Zhang <duwasai@gmail.com> * Update docs/root/configuration/http/http_filters/ip_tagging_filter.rst Co-authored-by: Addo.Zhang <duwasai@gmail.com> * Update docs/root/configuration/http/http_filters/ip_tagging_filter.rst Co-authored-by: Addo.Zhang <duwasai@gmail.com> * update translation issue Co-authored-by: Addo.Zhang <duwasai@gmail.com>
fixes #468