Merged
Conversation
1) httpConnPoolForCluster() can now be called when a cluster does not exist during normal operation (during router retry). Have it return nullptr in this case also. The router already handles the function returning nullptr so no other changes are needed. 2) When we remove a cluster, we need to drain the http connection pools for hosts in the cluster. 3) Correctly handle the cm initialize edge case where a cluster initialized, but then gets removed before overall initialization is complete. fixes #460
Member
Author
|
@lyft/network-team |
Member
|
Based on my high level understanding of the underlying drain, seems good to me. |
RomanDzhabarov
approved these changes
Feb 13, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
envoyproxy/envoy-mobile#489 Integrating https://github.com/rules-proto-grpc/rules_proto_grpc to unblock testing for our gRPC codec Followed the instructions for integrating with java here: https://github.com/rules-proto-grpc/rules_proto_grpc/tree/master/java Signed-off-by: Alan Chiu <achiu@lyft.com> Description: kotlin: Add simple grpc echo server/client Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
envoyproxy/envoy-mobile#489 Integrating https://github.com/rules-proto-grpc/rules_proto_grpc to unblock testing for our gRPC codec Followed the instructions for integrating with java here: https://github.com/rules-proto-grpc/rules_proto_grpc/tree/master/java Signed-off-by: Alan Chiu <achiu@lyft.com> Description: kotlin: Add simple grpc echo server/client Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during normal operation (during router retry). Have it return nullptr in
this case also. The router already handles the function returning nullptr
so no other changes are needed.
hosts in the cluster.
but then gets removed before overall initialization is complete.
fixes #460