Provide additional method for Base64::encode.#457
Merged
RomanDzhabarov merged 9 commits intomasterfrom Feb 13, 2017
Merged
Conversation
source/common/common/base64.h
Outdated
| /** | ||
| * Helper methods for encoding. | ||
| */ | ||
| static inline void encode_base(const uint8_t cur_char, uint64_t pos, uint8_t& next_c, |
| /** | ||
| * Base64 encode an input string. | ||
| * @param input string to encode. | ||
| */ |
Member
There was a problem hiding this comment.
make this take a const char* and a length, so it's usable outside of a string.
source/common/common/base64.h
Outdated
|
|
||
| private: | ||
| /** | ||
| * Helper methods for encoding. |
| * Helper methods for encoding. | ||
| */ | ||
| static void encodeBase(const uint8_t cur_char, uint64_t pos, uint8_t& next_c, std::string& ret); | ||
| /** |
Member
There was a problem hiding this comment.
nit: newline before this line
rshriram
reviewed
Feb 11, 2017
| /** | ||
| * Helper methods for encoding. | ||
| */ | ||
| static void encodeBase(const uint8_t cur_char, uint64_t pos, uint8_t& next_c, std::string& ret); |
Member
There was a problem hiding this comment.
nit: What does this method do? (you have comment for encodeLast, but none for encodeBase)
mattklein123
approved these changes
Feb 13, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Apr 13, 2020
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…agement.rst (envoyproxy#457) * finish http conn mgmt. * typo. * fix warning. * fix review suggest. * fix build error. * add http event trans.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Addresses crashes from locally-generated responses in Envoy leading to inconsistent stream state. A better fix will require an upstream change. Additionally, this adds a mechanism to map local error responses into error callbacks. This path could also be greatly improved with upstream changes. Risk Level: Low Testing: CI and local Signed-off-by: Jose Nino <jnino@lyft.com> Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Addresses crashes from locally-generated responses in Envoy leading to inconsistent stream state. A better fix will require an upstream change. Additionally, this adds a mechanism to map local error responses into error callbacks. This path could also be greatly improved with upstream changes. Risk Level: Low Testing: CI and local Signed-off-by: Jose Nino <jnino@lyft.com> Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This upgrades Go version to 1.24.1 as well as the direct dependencies. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.