dym: fix the bug where the struct cannot be used as configuration 2#43813
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Mar 6, 2026
Merged
dym: fix the bug where the struct cannot be used as configuration 2#43813wbpcode merged 1 commit intoenvoyproxy:mainfrom
wbpcode merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
mathetake
reviewed
Mar 6, 2026
Member
mathetake
left a comment
There was a problem hiding this comment.
is it possible to write a test?
Member
Author
We have common tests for the new knownAnyToBytes self. And also added integration test with http filter in preview PR. I think we may needn't to test the same logic for every different module type repeatedly? |
agrawroh
approved these changes
Mar 6, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…nvoyproxy#43813) Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym: fix the bug where the struct cannot be used as configuration 2
Additional Description:
Continuous work of #43791
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]