rust: take headers & trailers as slice, not vector#43799
Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom Mar 5, 2026
Merged
rust: take headers & trailers as slice, not vector#43799mathetake merged 1 commit intoenvoyproxy:mainfrom
mathetake merged 1 commit intoenvoyproxy:mainfrom
Conversation
This allows callers to provide a slice, which could be on the stack, instead of a Vec, which requires allocating on the heap. This is safe since the called functions weren't using the fact that they were taking ownership of the input, and were just producing a slice from the Vec internally and acting on that. Signed-off-by: Alex Bakon <abakon@netflix.com>
Contributor
Author
|
I don't know what the policy is around breaking changes to the dynamic modules SDKs. This is one since consuming Rust code will need to be adjusted to the new signatures. It's still ABI-compatible with the previous version, though. |
Member
|
nice! I think the SDK can be broken |
mathetake
approved these changes
Mar 5, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Commit Message: This allows callers to provide a slice, which could be on the stack, instead of a Vec, which requires allocating on the heap. This is safe since the called functions weren't using the fact that they were taking ownership of the input, and were just producing a slice from the Vec internally and acting on that. Additional Description: Since the changed methods are using `unsafe` code, the usual "if it compiles, it's safe" Rust guarantees around lifetimes don't apply. That being said, all the callers were already taking containers of references, so if there is any usage beyond the lifetimes of those values happening with this change, it was present in the previous version of the code. Risk Level: low Testing: build and ran unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Commit Message: This allows callers to provide a slice, which could be on the stack, instead of a Vec, which requires allocating on the heap. This is safe since the called functions weren't using the fact that they were taking ownership of the input, and were just producing a slice from the Vec internally and acting on that. Additional Description: Since the changed methods are using `unsafe` code, the usual "if it compiles, it's safe" Rust guarantees around lifetimes don't apply. That being said, all the callers were already taking containers of references, so if there is any usage beyond the lifetimes of those values happening with this change, it was present in the previous version of the code. Risk Level: low Testing: build and ran unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Commit Message: This allows callers to provide a slice, which could be on the stack, instead of a Vec, which requires allocating on the heap. This is safe since the called functions weren't using the fact that they were taking ownership of the input, and were just producing a slice from the Vec internally and acting on that. Additional Description: Since the changed methods are using `unsafe` code, the usual "if it compiles, it's safe" Rust guarantees around lifetimes don't apply. That being said, all the callers were already taking containers of references, so if there is any usage beyond the lifetimes of those values happening with this change, it was present in the previous version of the code. Risk Level: low Testing: build and ran unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This allows callers to provide a slice, which could be on the stack, instead of a Vec, which requires allocating on the heap. This is safe since the called functions weren't using the fact that they were taking ownership of the input, and were just producing a slice from the Vec internally and acting on that.
Additional Description:
Since the changed methods are using
unsafecode, the usual "if it compiles, it's safe" Rust guarantees around lifetimes don't apply. That being said, all the callers were already taking containers of references, so if there is any usage beyond the lifetimes of those values happening with this change, it was present in the previous version of the code.Risk Level: low
Testing: build and ran unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a