http: Fix flaky router integ test#43790
Merged
nezdolik merged 1 commit intoenvoyproxy:mainfrom Mar 6, 2026
Merged
Conversation
Signed-off-by: aakugan <aakashganapathy2@gmail.com>
nezdolik
approved these changes
Mar 6, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
## Commit Message Fix flaky router integ test usually surfaced as a segfault under asan ## Additional Description aakugan@4af388b Caused because the integ test makes a seperate thread for the upstream connection and the sentinel frame callback has a ptr to the ServerConnectionImpl which is usually not the case for actual workflows -> only one thread. After everything is shut down on the test thread the upstream thread can have a callback which crashes. Ref: https://github.com/envoyproxy/envoy/actions/runs/22659006942/job/65674847129#step:19:751 Signed-off-by: aakugan <aakashganapathy2@gmail.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
## Commit Message Fix flaky router integ test usually surfaced as a segfault under asan ## Additional Description aakugan@4af388b Caused because the integ test makes a seperate thread for the upstream connection and the sentinel frame callback has a ptr to the ServerConnectionImpl which is usually not the case for actual workflows -> only one thread. After everything is shut down on the test thread the upstream thread can have a callback which crashes. Ref: https://github.com/envoyproxy/envoy/actions/runs/22659006942/job/65674847129#step:19:751 Signed-off-by: aakugan <aakashganapathy2@gmail.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
## Commit Message Fix flaky router integ test usually surfaced as a segfault under asan ## Additional Description aakugan@4af388b Caused because the integ test makes a seperate thread for the upstream connection and the sentinel frame callback has a ptr to the ServerConnectionImpl which is usually not the case for actual workflows -> only one thread. After everything is shut down on the test thread the upstream thread can have a callback which crashes. Ref: https://github.com/envoyproxy/envoy/actions/runs/22659006942/job/65674847129#step:19:751 Signed-off-by: aakugan <aakashganapathy2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Fix flaky router integ test usually surfaced as a segfault under asan
Additional Description
aakugan@4af388b
Caused because the integ test makes a seperate thread for the upstream connection and the sentinel frame callback has a ptr to the ServerConnectionImpl which is usually not the case for actual workflows -> only one thread.
After everything is shut down on the test thread the upstream thread can have a callback which crashes.
Ref: https://github.com/envoyproxy/envoy/actions/runs/22659006942/job/65674847129#step:19:751