rust sdk: assert on the layout of header entries#43774
Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom Mar 4, 2026
Merged
rust sdk: assert on the layout of header entries#43774mathetake merged 1 commit intoenvoyproxy:mainfrom
mathetake merged 1 commit intoenvoyproxy:mainfrom
Conversation
d602656 to
c07ada9
Compare
Member
|
i think rust fmt is failing |
agrawroh
previously approved these changes
Mar 4, 2026
The Rust compiler doesn't guarantee that the layout of slices won't change. Add a type to encapsulate the unsafeness and assert that the transformation is safe in debug builds. Signed-off-by: Alex Bakon <abakon@netflix.com>
c07ada9 to
626c322
Compare
mathetake
approved these changes
Mar 4, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Commit Message: The Rust compiler doesn't guarantee that the layout of slices won't change. Add a type to encapsulate the unsafeness and assert that the transformation is safe in debug builds. Additional Description: Risk Level: low, this only adds assertions to catch future incompatibilities Testing: ran unit tests locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Commit Message: The Rust compiler doesn't guarantee that the layout of slices won't change. Add a type to encapsulate the unsafeness and assert that the transformation is safe in debug builds. Additional Description: Risk Level: low, this only adds assertions to catch future incompatibilities Testing: ran unit tests locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Commit Message: The Rust compiler doesn't guarantee that the layout of slices won't change. Add a type to encapsulate the unsafeness and assert that the transformation is safe in debug builds. Additional Description: Risk Level: low, this only adds assertions to catch future incompatibilities Testing: ran unit tests locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
The Rust compiler doesn't guarantee that the layout of slices won't change. Add a type to encapsulate the unsafeness and assert that the transformation is safe in debug builds.
Additional Description:
Risk Level: low, this only adds assertions to catch future incompatibilities
Testing: ran unit tests locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a