Skip to content

dym: fix the bug where the struct cannot be used as configuration#43753

Merged
wbpcode merged 6 commits intoenvoyproxy:mainfrom
wbpcode:dev-dynamic-module-config
Mar 5, 2026
Merged

dym: fix the bug where the struct cannot be used as configuration#43753
wbpcode merged 6 commits intoenvoyproxy:mainfrom
wbpcode:dev-dynamic-module-config

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented Mar 4, 2026

Commit Message: dym: fix the bug where the struct cannot be used as configuration
Additional Description:

All the comments of the dynamic module ABI told we can configure the google.protobuf.Struct and the the struct will be serialized as JSON but actually only part of them support it correctly.

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

wbpcode added 2 commits March 4, 2026 08:20
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode added 4 commits March 4, 2026 09:35
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Copy link
Copy Markdown
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@wbpcode wbpcode merged commit 9fc51ee into envoyproxy:main Mar 5, 2026
28 of 29 checks passed
@wbpcode wbpcode deleted the dev-dynamic-module-config branch March 5, 2026 01:06
bmjask pushed a commit to bmjask/envoy that referenced this pull request Mar 14, 2026
…voyproxy#43753)

Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants