dym sdk: add the config scheduler support to go sdk and cpp sdk#43748
Merged
wbpcode merged 4 commits intoenvoyproxy:mainfrom Mar 5, 2026
Merged
dym sdk: add the config scheduler support to go sdk and cpp sdk#43748wbpcode merged 4 commits intoenvoyproxy:mainfrom
wbpcode merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Member
Author
|
/retest |
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
… dev-add-config-scheduler-for-http
mathetake
previously approved these changes
Mar 4, 2026
Member
|
/retest |
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
commented
Mar 5, 2026
Comment on lines
+885
to
+888
| # This dynamic module SDK will be built into a shared library which we prefer to use | ||
| # standard library rather then the absl equivalents. We simply skip the content check | ||
| # for this directory to avoid false positives. | ||
| if self.run_code_validation and "dynamic_modules/sdk/cpp" not in file_path: |
Member
There was a problem hiding this comment.
couple of thoughts ...
is this specific enough - ie this will prevent any checks on these files - wondering if it should bail in check_source_line itself
if that is not the case then the right place to put this condition would be in the self.run_code_validation property i think
Member
There was a problem hiding this comment.
also - we have config for exclusions in the yaml file - so probably the exclusion should be set there
Member
Author
There was a problem hiding this comment.
also - we have config for exclusions in the yaml file - so probably the exclusion should be set there
The config is mostly be used to skip single item's check, like std::string_view or std::regex. What I may need to skip is the all std::* include std::string_view, std::mutex, std::optional, std::span, and so on.
to enhance and configure config.yaml would bring too much complexity to this already complex format check script self.
Member
There was a problem hiding this comment.
ok - realising also that the property wont work as its per-file - and dont feel strongly about the config - altho would say it kinda simplifies things (that was the reason for moving all the configs out of the logic)
agrawroh
approved these changes
Mar 5, 2026
Member
Author
|
/retest |
wbpcode
added a commit
to wbpcode/envoy
that referenced
this pull request
Mar 7, 2026
…yproxy#43748) Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk Additional Description: Add the config scheduler to go sdk and cpp sdk. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
added a commit
that referenced
this pull request
Mar 8, 2026
Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk Additional Description: Add the config scheduler to go sdk and cpp sdk. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…yproxy#43748) Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk Additional Description: Add the config scheduler to go sdk and cpp sdk. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…yproxy#43748) Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk Additional Description: Add the config scheduler to go sdk and cpp sdk. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…yproxy#43748) Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk Additional Description: Add the config scheduler to go sdk and cpp sdk. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym sdk: add the config scheduler support to go sdk and cpp sdk
Additional Description:
Add the config scheduler to go sdk and cpp sdk.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]