tcp_proxy: fix OD-CDS over ADS#43529
Merged
botengyao merged 6 commits intoenvoyproxy:mainfrom Feb 20, 2026
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
…r_ads_fix Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
Assigning the same maintainers from #41174 and a senior-maintainer |
…r_ads_fix Signed-off-by: Adi Suissa-Peleg <adip@google.com>
KBaichoo
previously approved these changes
Feb 18, 2026
KBaichoo
previously approved these changes
Feb 18, 2026
nezdolik
previously approved these changes
Feb 19, 2026
botengyao
reviewed
Feb 19, 2026
Member
botengyao
left a comment
There was a problem hiding this comment.
lgtm module one q, thanks!
/wait
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
botengyao
approved these changes
Feb 20, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Commit Message: tcp_proxy: fix OD-CDS over ADS Additional Description: This PR is similar to envoyproxy#41174 (and uses the same component to achieve the same goal). The fix allows proper use of tcp_proxy on-demand cluster discovery when used over ADS. Risk Level: low - only impacts OD-CDS over tcp_proxy Testing: Added integration tests. Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: Added `envoy.reloadable_features.tcp_proxy_odcds_over_ads_fix` to disable the behavior. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Commit Message: tcp_proxy: fix OD-CDS over ADS Additional Description: This PR is similar to envoyproxy#41174 (and uses the same component to achieve the same goal). The fix allows proper use of tcp_proxy on-demand cluster discovery when used over ADS. Risk Level: low - only impacts OD-CDS over tcp_proxy Testing: Added integration tests. Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: Added `envoy.reloadable_features.tcp_proxy_odcds_over_ads_fix` to disable the behavior. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Commit Message: tcp_proxy: fix OD-CDS over ADS Additional Description: This PR is similar to envoyproxy#41174 (and uses the same component to achieve the same goal). The fix allows proper use of tcp_proxy on-demand cluster discovery when used over ADS. Risk Level: low - only impacts OD-CDS over tcp_proxy Testing: Added integration tests. Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: Added `envoy.reloadable_features.tcp_proxy_odcds_over_ads_fix` to disable the behavior. --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: tcp_proxy: fix OD-CDS over ADS
Additional Description:
This PR is similar to #41174 (and uses the same component to achieve the same goal).
The fix allows proper use of tcp_proxy on-demand cluster discovery when used over ADS.
Risk Level: low - only impacts OD-CDS over tcp_proxy
Testing: Added integration tests.
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: Added
envoy.reloadable_features.tcp_proxy_odcds_over_ads_fixto disable the behavior.