Skip to content

release/contrib: Fix and test distroless publishing#43385

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:publish-contrib-version
Feb 8, 2026
Merged

release/contrib: Fix and test distroless publishing#43385
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:publish-contrib-version

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Feb 8, 2026

  • add a -contrib suffix to the version string
  • test version strings for suffixes
  • fix distroless contrib binary
  • add a test to ensure binary in distroless contrib is really contrib
  • fix distroless ci to ensure just-built image is the one tested

Fix #43382

@phlax phlax force-pushed the publish-contrib-version branch from 7fe66e4 to 7498a8c Compare February 8, 2026 10:22
@phlax phlax force-pushed the publish-contrib-version branch from 7498a8c to 6952c45 Compare February 8, 2026 10:33
@phlax phlax changed the title release/binary: Add contrib to version string [WIP] release/contrib: Fix and test contrib docker publishing Feb 8, 2026
@phlax phlax marked this pull request as draft February 8, 2026 10:35
@phlax phlax force-pushed the publish-contrib-version branch 6 times, most recently from c4db19c to 69e0d78 Compare February 8, 2026 13:47
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 8, 2026

FAIL: contrib-distroless does NOT contain contrib binary - version:
/usr/local/bin/envoy  version: 5151379e36c8c9373de231b8ff07abda1d524ea9/1.38.0-dev/Clean/RELEASE/BoringSSL

works but we probs want the error to bubble

@phlax phlax force-pushed the publish-contrib-version branch 3 times, most recently from 07e391c to 69b5675 Compare February 8, 2026 17:21
@phlax phlax force-pushed the publish-contrib-version branch 3 times, most recently from 9978947 to f04902e Compare February 8, 2026 17:30
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the publish-contrib-version branch from f04902e to 86a4a8c Compare February 8, 2026 20:03
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 8, 2026

/retest transient

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 8, 2026

/retest flake

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 8, 2026

tested in staging - will make into an error once it lands the binary (and ci) is fixed

@phlax phlax changed the title [WIP] release/contrib: Fix and test contrib docker publishing release/contrib: Fix and test contrib docker publishing Feb 8, 2026
@phlax phlax marked this pull request as ready for review February 8, 2026 20:38
@phlax phlax requested a review from agrawroh as a code owner February 8, 2026 20:38
agrawroh
agrawroh previously approved these changes Feb 8, 2026
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title release/contrib: Fix and test contrib docker publishing release/contrib: Fix and test distrolesspublishing Feb 8, 2026
@phlax phlax changed the title release/contrib: Fix and test distrolesspublishing release/contrib: Fix and test distroless publishing Feb 8, 2026
@phlax phlax enabled auto-merge (squash) February 8, 2026 21:11
@phlax phlax merged commit bd8758a into envoyproxy:main Feb 8, 2026
27 checks passed
shane-yuan pushed a commit to shane-yuan/envoy that referenced this pull request Feb 11, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 13, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 13, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 20, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Feb 20, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix #43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
nickshokri pushed a commit to nickshokri/envoy that referenced this pull request Mar 17, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: nick <nickshokri@google.com>
nickshokri pushed a commit to nickshokri/envoy that referenced this pull request Mar 17, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: nick <nickshokri@google.com>
fishcakez pushed a commit to fishcakez/envoy that referenced this pull request Mar 25, 2026
- add a `-contrib` suffix to the version string
- test version strings for suffixes
- fix distroless contrib binary
- add a test to ensure binary in distroless contrib is really contrib
- fix distroless ci to ensure just-built image is the one tested

Fix envoyproxy#43382

---------

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

contrib-distroless does not contain Golang HTTP filter (proto) extension

2 participants