API: new composite API for inline matcher#43227
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
Regardless of discussion at #42912, @markdroth I think this is something we could easily get agreement. Although I need some time to re-consider the implementation. We still need to keep backward compatibility to the previous version. We need some hack to validate the new style and old style will not be used at same time. 🤔 But we can land the API first. BTW, although Envoy need to keep backward compatibility, but gRPC may could have a fresh start if the feature haven't been released in the gRPC? |
|
/lgtm api
Absolutely! This looks great!
What I was thinking is this:
Either API would result in the same filter being configured.
Sadly, it's probably too late for that. I've already started implementing the composite filter in gRPC C++, since we need it fairly quickly for an important feature, and we're going to need to deploy it in an environment where the control plane supports both gRPC and Envoy. I don't think there's enough time to get the new API implemented in Envoy and get all of our Envoy instances upgraded before we need to deploy this. :( On the plus side, once we agree on this new API, it will be trivial for gRPC to add support for it. |
Yeah, exactly. This is what I am thinking. Although in the Envoy, there is no way for filter implementation to know whether it's configured in the ExtensionWithMatcher or top level filter chain. Still need some hack. Anyway, I will try to resolve this problem and add implementation at next 2-3 weeks. |
|
cc @agrawroh for an approval for this API only change. Then I can prepare the implementation. This is independent topic about how to improve composite self. (For now, TBH, it's over-complicated even as an expert-tool. Orz). |
Signed-off-by: code <wbphub@gmail.com>
|
because Mark have approved this API before, let's merge it directly. |
Signed-off-by: nick <nickshokri@google.com>
Signed-off-by: nick <nickshokri@google.com>
Commit Message: composite: new API for inline matcher
Additional Description:
Add matcher API to the composite filter directly to avoid dependency to ExtensionWithMatcher. This would make the the filter a little easier to use.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]