mobile/bazel: Remove very old foreign_cc pin#42096
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Nov 18, 2025
Merged
Conversation
Not clear if this is needed the related PR (bazel-contrib/rules_foreign_cc#938) never landed, but it seems the pinned version is not compatible with hermetic toolchains Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
@keith i have the hermetic toolchains more/less working for mobile - but this foreign_cc pin is breaking (at least one) one of the builds not sure if the original problem is resolved (bazel-contrib/rules_foreign_cc#938) - but worst case i think i can just pick that pr as a patch, and then at least we wont be stuck on a very old version |
abeyad
approved these changes
Nov 18, 2025
Member
Author
|
lets land it on the basis that it passes ci - if the need arises we can pick the pr as a patch in the future |
Member
|
i kinda feel like that was fixed some other way but idk. seems fine to land and see how it goes. a bit annoying if it quietly picks up another xcode but hopefully it will fail loudly if so |
Member
Author
|
would be good to add some kinda ci to detect if we can but its not easy for me to test locally |
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Not clear if this is needed - the related PR (bazel-contrib/rules_foreign_cc#938) never landed, but it seems the pinned version is not compatible with hermetic toolchains Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not clear if this is needed - the related PR (bazel-contrib/rules_foreign_cc#938) never landed, but it seems the pinned version is not compatible with hermetic toolchains