Skip to content

Use mutex reference in lock constructors p8#41948

Merged
KBaichoo merged 1 commit intoenvoyproxy:mainfrom
adisuissa:mutex_lock_update5
Nov 11, 2025
Merged

Use mutex reference in lock constructors p8#41948
KBaichoo merged 1 commit intoenvoyproxy:mainfrom
adisuissa:mutex_lock_update5

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa commented Nov 10, 2025

Replace deprecated absl::MutexLock::MutexLock(Mutex*) constructor with absl::MutexLock::MutexLock(Mutex&)

Additional Description: needed due to upcoming absl change.
Similar to #41208.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@adisuissa
Use mutex reference in lock constructors p8
34e4edd 
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa adisuissa marked this pull request as ready for review November 10, 2025 17:55
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Nov 10, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41948 was opened by adisuissa.

see: more, trace.

@adisuissa
Copy link
Copy Markdown
Contributor Author

adisuissa commented Nov 11, 2025

/assign @KBaichoo

KBaichoo
KBaichoo approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@KBaichoo KBaichoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KBaichoo KBaichoo merged commit eb6c7d4 into envoyproxy:main Nov 11, 2025
24 checks passed
This was referenced Dec 17, 2025
Merged
Merged
botengyao added a commit that referenced this pull request Dec 17, 2025
@botengyao
clean-up: use Mutex reference p1 (#42670)
692bc00 
Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to #41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
botengyao added a commit that referenced this pull request Dec 17, 2025
@botengyao
clean-up: use Mutex reference and change lock interface p2 (#42673)
8b1f88d 
Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to #41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Dec 18, 2025
@botengyao @TAOXUY
clean-up: use Mutex reference p1 (envoyproxy#42670)
0e46a13 
Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to envoyproxy#41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Dec 18, 2025
@botengyao @TAOXUY
clean-up: use Mutex reference and change lock interface p2 (envoyprox…
ec1ecf7 
…y#42673)

Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to envoyproxy#41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@adisuissa @grnmeira
Use mutex reference in lock constructors p8 (envoyproxy#41948)
ebb8f52 
Replace deprecated absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)

Additional Description: needed due to upcoming absl change.
Similar to envoyproxy#41208.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@botengyao @grnmeira
clean-up: use Mutex reference p1 (envoyproxy#42670)
d8bfc5d 
Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to envoyproxy#41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@botengyao @grnmeira
clean-up: use Mutex reference and change lock interface p2 (envoyprox…
0031a81 
…y#42673)

Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to envoyproxy#41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KBaichoo KBaichoo KBaichoo approved these changes

Assignees

@KBaichoo KBaichoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adisuissa @KBaichoo