Skip to content

mobile/coverage: Fix and remove awful hack#41209

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:mobile-coverage-toolchain
Sep 24, 2025
Merged

mobile/coverage: Fix and remove awful hack#41209
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:mobile-coverage-toolchain

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Sep 24, 2025

No description provided.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Sep 24, 2025

tested in staging

Copy link
Copy Markdown
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks @phlax !

@phlax phlax enabled auto-merge (squash) September 24, 2025 18:33
@phlax phlax merged commit c4d23a1 into envoyproxy:main Sep 24, 2025
24 checks passed
davidben added a commit to google/boringssl that referenced this pull request Nov 10, 2025
bazelbuild/bazel#23792 is available in Bazel
7.4.0 or later. [0] has long set a minimum Bazel version of Bazel 7 and,
as of [1], Envoy has since caught up. We should be able to rely on this
now, and
remove the workaround.

This doesn't enable parse_headers, but clears the Bazel blocker.

Update-Note: BoringSSL now requires Bazel 7.4.0 or later.

[0] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
[1] envoyproxy/envoy#41209

Bug: 399387924
Change-Id: Icf2278d9fe8f0f38f353ce87dd227bd4bf0ac95c
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/76787
Commit-Queue: David Benjamin <davidben@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants