xds-federation: adding support for OD-CDS over xDS-TP concurrent with CDS SotW#41117
Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom Sep 18, 2025
Merged
Conversation
… CDS SotW Signed-off-by: Adi Suissa-Peleg <adip@google.com>
…urces Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
As in #40988, assigning @KBaichoo as potential OD-CDS user (no impact on the non-xDS-TP path at the moment, but feel free to comment), and @yanavlasov and @nezdolik for config-path reviewers. |
…urces Signed-off-by: Adi Suissa-Peleg <adip@google.com>
yanavlasov
approved these changes
Sep 18, 2025
mbadov
pushed a commit
to mbadov/envoy
that referenced
this pull request
Sep 22, 2025
… CDS SotW (envoyproxy#41117) Prior to this PR, an Envoy that used (old) ADS over SotW to fetch all the clusters and a xDS-TP-config-based source to fetch OD-CDS would see the OD-CDS clusters removed once the ADS update arrives. This PR, changes the SotW CDS wildcard update, and adds tracking to see which resources are fetched from that source. The tracking is only used if both (old) ADS and an xDS-TP based config is configured. This implementation is currently only for CDS, but will need to be part of the (future) xDS-Cache layer. Continuation of envoyproxy#40988. Risk Level: low - should only impact cases that use xDS-TP based configs (guarded by a false by default runtime guard). Testing: Added both unit and integration test. Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Misha Badov <mbadov@google.com>
|
This scenario also applies when:
We implemented a work around in the go-control-plane cache. However, I'd like to contribute here and fix this case in Envoy itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: xds-federation: adding support for OD-CDS over xDS-TP concurrent with CDS SotW
Additional Description:
Prior to this PR, an Envoy that used (old) ADS over SotW to fetch all the clusters and a xDS-TP-config-based source to fetch OD-CDS would see the OD-CDS clusters removed once the ADS update arrives.
This PR, changes the SotW CDS wildcard update, and adds tracking to see which resources are fetched from that source. The tracking is only used if both (old) ADS and an xDS-TP based config is configured.
This implementation is currently only for CDS, but will need to be part of the (future) xDS-Cache layer.
Continuation of #40988.
Risk Level: low - should only impact cases that use xDS-TP based configs (guarded by a false by default runtime guard).
Testing: Added both unit and integration test.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A