load_balancers: fix crash on invalid endpoint update with health checks#41114
load_balancers: fix crash on invalid endpoint update with health checks#41114ggreenway merged 7 commits intoenvoyproxy:mainfrom
Conversation
Fixes envoyproxy#41102 Signed-off-by: Greg Greenway <ggreenway@apple.com>
a43b1e3 to
7370540
Compare
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
Is these necessary to make the validator part of load balancer config? Seems it's a common validation that should always be applied in all cases and has non-business with LB directly? /wait-any |
|
This validation has always been part of these particular load balancers. If we made it common, we may end up rejecting a config that was previously valid, and that still works. But also, I discovered this crash while working on a load balancer internally that requires specific metadata on each endpoint and rejects the endpoints if it isn't present. I think it's reasonable for load balancers to have the opportunity to reject sets of endpoints. |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #41102