dynamic_modules: link dynamic library lifetime with per route config#41112
Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom Sep 17, 2025
Merged
Conversation
Signed-off-by: William Zhang <wtzhang23@gmail.com>
Contributor
Author
|
With this change: |
mbadov
pushed a commit
to mbadov/envoy
that referenced
this pull request
Sep 22, 2025
…nvoyproxy#41112) Commit Message: dynamic_modules: link dynamic library lifetime with per route config Additional Description: Pass the RAII handle to the dynamic library to the per route config to ensure that at least one ref count for the dynamic library exists while the per route config is active. This can avoid the library from being closed and unmapped from the process should no filter config be active while per route configs are. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Fixes envoyproxy#41094 Signed-off-by: William Zhang <wtzhang23@gmail.com> Signed-off-by: Misha Badov <mbadov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic_modules: link dynamic library lifetime with per route config
Additional Description: Pass the RAII handle to the dynamic library to the per route config to ensure that at least one ref count for the dynamic library exists while the per route config is active. This can avoid the library from being closed and unmapped from the process should no filter config be active while per route configs are.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Potentially fixes #41094