dynamic_modules: make sure rust's new_http_filter entrypoint matches the c abi#40864
Merged
mathetake merged 2 commits intoenvoyproxy:mainfrom Aug 27, 2025
Merged
Conversation
Signed-off-by: William Zhang <wtzhang23@gmail.com>
Signed-off-by: William Zhang <wtzhang23@gmail.com>
Member
|
Oh wow this is absolutely making sense... good catch.. |
mathetake
approved these changes
Aug 27, 2025
Member
mathetake
left a comment
There was a problem hiding this comment.
Thank you so much, this is absolutely LGTM. Good catch.
/retest
Member
|
/retest |
wtzhang23
added a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
…the c abi (envoyproxy#40864) Commit Message: dynamic_modules: make sure rust's new_http_filter entrypoint matches the c abi Additional Description: Currently, for the second argument `filter_envoy_ptr` of the `envoy_dynamic_module_on_http_filter_new` entrypoint, the Rust `new_http_filter` function expects to take a pointer to `DynamicModuleHttpFilterConfig` but should take in `DynamicModuleHttpFilter` as declared in the [C abi](https://github.com/envoyproxy/envoy/blob/55f965713e99769c729f87680c7349fd2307f6b7/source/extensions/dynamic_modules/abi.h#L571-L573). Risk Level: low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: William Zhang <wtzhang23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic_modules: make sure rust's new_http_filter entrypoint matches the c abi
Additional Description: Currently, for the second argument
filter_envoy_ptrof theenvoy_dynamic_module_on_http_filter_newentrypoint, the Rustnew_http_filterfunction expects to take a pointer toDynamicModuleHttpFilterConfigbut should take inDynamicModuleHttpFilteras declared in the C abi.Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A