upstream: introduce new drain behavior DrainExistingNonMigratableConnections#40801
Merged
RyanTheOptimist merged 8 commits intoenvoyproxy:mainfrom Aug 22, 2025
Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @abeyad |
Signed-off-by: Dan Zhang <danzh@google.com>
abeyad
previously approved these changes
Aug 21, 2025
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
abeyad
approved these changes
Aug 21, 2025
Contributor
|
Since this touches non-mobile code, you'll also need to get approval from a maintainer |
Contributor
Author
|
/assign @RyanTheOptimist |
RyanTheOptimist
approved these changes
Aug 22, 2025
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
…ections (envoyproxy#40801) Commit Message: Introduces new enum value `ConnectionPool::DrainBehavior::DrainExistingNonMigratableConnections`. When this behavior is used, HTTP/3 connection pools will only drain existing connections if QUIC connection migration is not enabled. The mobile engine is updated to use this new drain behavior when DNS refreshing is disabled on network changes, allowing migratable QUIC connections to persist across network transitions. Additional Description: also add QUICHE migration code into build target Risk Level: low, the new behavior is disabled Testing: new unit test pass Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
wtzhang23
pushed a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
…ections (envoyproxy#40801) Commit Message: Introduces new enum value `ConnectionPool::DrainBehavior::DrainExistingNonMigratableConnections`. When this behavior is used, HTTP/3 connection pools will only drain existing connections if QUIC connection migration is not enabled. The mobile engine is updated to use this new drain behavior when DNS refreshing is disabled on network changes, allowing migratable QUIC connections to persist across network transitions. Additional Description: also add QUICHE migration code into build target Risk Level: low, the new behavior is disabled Testing: new unit test pass Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Introduces new enum value
ConnectionPool::DrainBehavior::DrainExistingNonMigratableConnections. When this behavior is used, HTTP/3 connection pools will only drain existing connections if QUIC connection migration is not enabled.The mobile engine is updated to use this new drain behavior when DNS refreshing is disabled on network changes, allowing migratable QUIC connections to persist across network transitions.
Additional Description: also add QUICHE migration code into build target
Risk Level: low, the new behavior is disabled
Testing: new unit test pass
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A