Automatic dockerhub builds by junr03 · Pull Request #408 · envoyproxy/envoy

junr03 · 2017-02-01T23:08:50Z

@lyft/network-team

I have added two new scripts to CI:

ci/docker_push.sh: this file creates a lyft/envoy:latest image that is used by script 2. and gets push to dockerhub if the current branch is master. This will cause our lyft/envoy:latest image to be updated every time a PR is merged to master.
ci/verify_examples.sh: this file builds our examples and verifies that all the containers run. This is the way I devised to verify that our examples build and run on every PR. The grpc-bridge example is a little convoluted because travis does not allow multi-lingual environments so I had to install go, and setup the project on a gopath.

Both scripts are part of the script portion of CI so that their failure causes test failure and people notice them. Both scripts only run on the normal env.

mattklein123 · 2017-02-01T23:17:07Z

examples/Dockerfile-envoy-image

 RUN apt-get update && apt-get install -y \
    curl \
    python-pip
+RUN objcopy --only-keep-debug /usr/local/bin/envoy /usr/local/bin/envoy.dbg


For now I would just strip and drop the debug symbols to make the image smaller. If people want the debug symbols we can deal with that later. Also, do we need curl and python above? Can that be deleted?

Ok, dropping debug. The curl and python above are needed in the examples. I could move their addition to the examples' docker file. If we want that, then I would move this Dockerfile to ci/; at that point this dockerfile would belong there rather than here. What do you think?

Yeah let's keep this as clean/simple as possible.

rshriram · 2017-02-02T04:16:01Z

ci/docker_push.sh

+then
+    # docker login -e $DOCKER_EMAIL -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
+    export TAG=`if [ "$TRAVIS_BRANCH" == "master" ]; then echo "latest"; else echo $TRAVIS_BRANCH; fi`
+    echo "TAG is $TAG"


Any thoughts on tagging based on semantic versioning?
i.e., master branch can be "unstable", while a.b.c could be tagged with tags: envoy:a, envoy:a.b, envoy:a.b.c, and envoy:latest pointing to the a.b.c
However, if you are maintaining 1.0.0 and 1.1.0 branch for internal purposes, then please disregard the comment above.

The 1.0.0 and 1.1.0 stuff was copied from somewhere else. We will delete that. I have no preference on whether we call master unstable or latest. Whatever folks want is fine.

I think for now, as long as we are building on every master commit, we will end up manually tagging each release, and can also point latest at that release. (Need docs on this, and eventually potentially a script for doing an official release).

mattklein123 · 2017-02-02T16:14:08Z

ci/Dockerfile-envoy-image

 RUN apt-get update && apt-get install -y \
-    curl \
-    python-pip
+    build-essential


what is this? do we need it?

just for strip?

Yeah just for strip. I was trying to find if it could be installed individually but didn't find an alt package for it.

mattklein123 · 2017-02-02T16:15:04Z

ci/docker_push.sh

+#!/bin/bash
+set -ev
+want_push='false'
+for branch in "master" "1.0.0" "1.1.0"


we don't do versioned branches right now, let's just delete 1.0.0 and 1.1.0

Yep, that's going away

Initially I thought these would work for our tagged releases but then I realized this would require us maintaining actual release branches not just having a tagged release.

mattklein123 · 2017-02-06T23:33:51Z

ci/build_container/update_build_container.sh

+read -r -p "Are you on master and have a clean branch? [y/N] " response
+if [[ $response =~ ^([yY][eE][sS]|[yY])$ ]]
+then
+  read -r -p "What SHA do you want to tag the envoy-build with? [y/N] " tag


can we just read this from git rev-parse and not ask the user

cool, I didn't know about this.

mattklein123 · 2017-02-06T23:34:06Z

ci/build_container/update_build_container.sh

+  eval $(docker-machine env default)
+  docker build --rm -t lyft/envoy-build:$tag .
+  docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
+  docker push lyft/envoy-build:$tag


can we also tag latest, better for dev

mattklein123 · 2017-02-07T00:12:27Z

ci/build_container/update_build_container.sh

+read -r -p "Do you have master checked out with most recent changes? [y/N] " response
+if [[ $response =~ ^([yY][eE][sS]|[yY])$ ]]
+then
+  TAG="$(git rev-parse origin/master)"


this should be master, not origin/master, as your local my not be up to date and that is what you are building.

Agreed, that way there is no divergence between the tag and what was actually built.

Automatic merge from submit-queue. Tcp filter report delta **What this PR does / why we need it**: Let MixerClient send periodical reports for long TCP connections. Use config TcpClientConfig::report_interval to set report interval. If report_interval is not set, or report_interval is not correct, then use 10 seconds as default interval. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #[539](https://github.com/istio/proxy/issues/539) **Special notes for your reviewer**: **Release note**: ```release-note ```

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…am from 1.6.9 to 1.6.10 (#408)

junr03 changed the title ~~Test~~ Automatic dockerhub builds Feb 1, 2017

mattklein123 reviewed Feb 1, 2017

View reviewed changes

rshriram reviewed Feb 2, 2017

View reviewed changes

mattklein123 reviewed Feb 2, 2017

View reviewed changes

Add example testing and envoy image push on CI

0557a61

junr03 force-pushed the automatic-builds branch from 42e3c2c to 0557a61 Compare February 3, 2017 17:28

Jose Nino added 2 commits February 3, 2017 09:31

Purge build-essential

94a0930

test

fd61d77

junr03 closed this Feb 6, 2017

junr03 reopened this Feb 6, 2017

Add build image script

67b1fc8

junr03 mentioned this pull request Feb 6, 2017

build: update docker image on every master commit that passes tests #155

Closed

mattklein123 reviewed Feb 6, 2017

View reviewed changes

Jose Nino added 4 commits February 6, 2017 15:47

Auto tag, also push latest

eec6852

Merge branch 'master' into automatic-builds

d72f1c4

Update envoy-build tag on travis

4a1339a

fix echo

eabffc4

mattklein123 reviewed Feb 7, 2017

View reviewed changes

fix

a4dc6f0

mattklein123 approved these changes Feb 7, 2017

View reviewed changes

junr03 merged commit dd56c54 into master Feb 7, 2017

junr03 deleted the automatic-builds branch February 7, 2017 17:55

mattklein123 mentioned this pull request Feb 8, 2017

Some extra developer conveniences for Docker image. #437

Merged

rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018

Added source.ip port for http. (envoyproxy#408)

dbdf74c

PiotrSikora pushed a commit to istio/envoy that referenced this pull request Feb 24, 2020

Switch example to use v8. (envoyproxy#408)

d6ebd63

Signed-off-by: John Plevyak <jplevyak@gmail.com>

mathetake pushed a commit that referenced this pull request Mar 3, 2026

build(deps): bump github.com/aws/aws-sdk-go-v2/aws/protocol/eventstre…

0841aa5

…am from 1.6.9 to 1.6.10 (#408)

Conversation

junr03 commented Feb 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

junr03 commented Feb 1, 2017 •

edited

Loading