Skip to content

Unconditionally set request headers in decodeHeaders call for ratelimit filter#40760

Merged
adisuissa merged 3 commits intoenvoyproxy:mainfrom
pradeepcrao:ratelimit
Aug 22, 2025
Merged

Unconditionally set request headers in decodeHeaders call for ratelimit filter#40760
adisuissa merged 3 commits intoenvoyproxy:mainfrom
pradeepcrao:ratelimit

Conversation

@pradeepcrao
Copy link
Copy Markdown
Contributor

Commit Message:
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

…it filter.

Signed-off-by: pcrao <pcrao@google.com>
@pradeepcrao
Copy link
Copy Markdown
Contributor Author

These changes are required to enable fuzz testing for the ratelimit filter and prevent this failure

@adisuissa adisuissa self-assigned this Aug 18, 2025
adisuissa
adisuissa previously approved these changes Aug 18, 2025
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa
Copy link
Copy Markdown
Contributor

/assign @envoyproxy/senior-maintainers

@repokitteh-read-only
Copy link
Copy Markdown

@envoyproxy/senior-maintainers cannot be assigned to this issue.

🐱

Caused by: a #40760 (comment) was created by @adisuissa.

see: more, trace.

@adisuissa
Copy link
Copy Markdown
Contributor

/assign-from @envoyproxy/senior-maintainers

@repokitteh-read-only
Copy link
Copy Markdown

@envoyproxy/senior-maintainers assignee is @zuercher

🐱

Caused by: a #40760 (comment) was created by @adisuissa.

see: more, trace.

@pradeepcrao
Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: pcrao <pcrao@google.com>
Signed-off-by: pcrao <pcrao@google.com>
Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pradeepcrao
Copy link
Copy Markdown
Contributor Author

@wbpcode Does this look good to you after my latest commit?

@pradeepcrao
Copy link
Copy Markdown
Contributor Author

@zuercher @adisuissa Is this good to merge?

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa
Copy link
Copy Markdown
Contributor

Approved by a senior-maintainer, merging.

@adisuissa adisuissa merged commit b6ac394 into envoyproxy:main Aug 22, 2025
24 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Aug 23, 2025
melginaldi pushed a commit to melginaldi/envoy that referenced this pull request Aug 26, 2025
… for ratelimit filter (envoyproxy#40760)

Signed-off-by: pcrao <pcrao@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
melginaldi pushed a commit to melginaldi/envoy that referenced this pull request Aug 26, 2025
… for ratelimit filter (envoyproxy#40760)

Signed-off-by: pcrao <pcrao@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
wtzhang23 pushed a commit to wtzhang23/envoy that referenced this pull request Aug 27, 2025
… for ratelimit filter (envoyproxy#40760)

Signed-off-by: pcrao <pcrao@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants