generic proxy: add onDownstreamConnected() callback to ServerCodec#40747
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Aug 22, 2025
Merged
Conversation
wbpcode
reviewed
Aug 16, 2025
Comment on lines
+31
to
+37
| /** | ||
| * Called when the downstream connection is established. | ||
| * | ||
| * The connection obtained from ServerCodecCallbacks::connection() will be valid when this | ||
| * callback is invoked. It should not be relied upon to be valid until this point. | ||
| */ | ||
| virtual void onDownstreamConnected() {} |
Member
There was a problem hiding this comment.
How about just name it onConnected() (simple) or onNewConnection() (keep same with the network filter)?
Contributor
Author
There was a problem hiding this comment.
onConnected() works. I thought the name might be too be ambiguous, but it's probably fine. Naming it onNewConnection() might harm searchability.
Signed-off-by: Joe Kralicky <joekralicky@gmail.com>
cfd4147 to
d131c71
Compare
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
…nvoyproxy#40747) Commit Message: generic proxy: add onDownstreamConnected() callback to ServerCodec Additional Description: This adds a new method ServerCodec::onDownstreamConnected() that is called when the downstream connection is established. This can be used for initialization steps that require the connection returned by ServerCodecCallbacks::connection() to have a value and be in a connected state. Risk Level: Low; the new method has an empty default implementation, as to not break existing ServerCodec implementations. Testing: Updated unit tests and mocks Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
…nvoyproxy#40747) Commit Message: generic proxy: add onDownstreamConnected() callback to ServerCodec Additional Description: This adds a new method ServerCodec::onDownstreamConnected() that is called when the downstream connection is established. This can be used for initialization steps that require the connection returned by ServerCodecCallbacks::connection() to have a value and be in a connected state. Risk Level: Low; the new method has an empty default implementation, as to not break existing ServerCodec implementations. Testing: Updated unit tests and mocks Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
wtzhang23
pushed a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
…nvoyproxy#40747) Commit Message: generic proxy: add onDownstreamConnected() callback to ServerCodec Additional Description: This adds a new method ServerCodec::onDownstreamConnected() that is called when the downstream connection is established. This can be used for initialization steps that require the connection returned by ServerCodecCallbacks::connection() to have a value and be in a connected state. Risk Level: Low; the new method has an empty default implementation, as to not break existing ServerCodec implementations. Testing: Updated unit tests and mocks Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: Joe Kralicky <joekralicky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: generic proxy: add onDownstreamConnected() callback to ServerCodec
Additional Description:
This adds a new method ServerCodec::onDownstreamConnected() that is called when the downstream connection is established. This can be used for initialization steps that require the connection returned by ServerCodecCallbacks::connection() to have a value and be in a connected state.
Risk Level: Low; the new method has an empty default implementation, as to not break existing ServerCodec implementations.
Testing: Updated unit tests and mocks
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]