Skip to content

dynamic_modules: adds logging ABI#40496

Merged
wbpcode merged 7 commits intoenvoyproxy:mainfrom
mathetake:dynamicmodulesenvoyloggin
Aug 12, 2025
Merged

dynamic_modules: adds logging ABI#40496
wbpcode merged 7 commits intoenvoyproxy:mainfrom
mathetake:dynamicmodulesenvoyloggin

Conversation

@mathetake
Copy link
Copy Markdown
Member

Commit Message: dynamic_modules: adds logging ABI
Additional Description:

This commit adds two new functions to the dynamic modules ABI:

  • envoy_dynamic_module_callback_log
  • envoy_dynamic_module_callback_log_enabled

This enables modules to do logging just like the native envoy filters through the envoy logging stream.

Closes #40143

Risk Level: none (100% new optional code path)
Testing: done
Docs Changes: done
Release Notes: n/a
Platform Specific Features: n/a

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #40496 was opened by mathetake.

see: more, trace.

@mathetake mathetake force-pushed the dynamicmodulesenvoyloggin branch from a26ef45 to b87391b Compare July 30, 2025 21:53
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake force-pushed the dynamicmodulesenvoyloggin branch from b87391b to 4510aff Compare July 30, 2025 21:55
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Copy Markdown
Member Author

/coverage

@repokitteh-read-only
Copy link
Copy Markdown

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/40496/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

🐱

Caused by: a #40496 (comment) was created by @mathetake.

see: more, trace.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake marked this pull request as ready for review July 30, 2025 23:42
@mathetake mathetake requested a review from mattklein123 as a code owner July 30, 2025 23:42
@mathetake mathetake requested a review from wbpcode July 30, 2025 23:42
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Aug 5, 2025

this may have to wait for a review from @wbpcode

wbpcode
wbpcode previously approved these changes Aug 9, 2025
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Aug 9, 2025

Please add a change log. Thanks.

/wait

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Aug 12, 2025

LGTM. Thanks.

@wbpcode wbpcode merged commit 2512b1d into envoyproxy:main Aug 12, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dynamic modules: log ABI support

3 participants