aws: assumerole missing protobuf validations#40273
Merged
mattklein123 merged 11 commits intoenvoyproxy:mainfrom Aug 21, 2025
Merged
aws: assumerole missing protobuf validations#40273mattklein123 merged 11 commits intoenvoyproxy:mainfrom
mattklein123 merged 11 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @RyanTheOptimist |
adisuissa
reviewed
Jul 24, 2025
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
Thanks, overall LGTM.
Is this a bug-fix? If so, should there be a release note?
Also, just to make sure, this doesn't break previous configs, right?
/wait-any
source/extensions/common/aws/credential_providers/assume_role_credentials_provider.cc
Show resolved
Hide resolved
source/extensions/common/aws/credential_providers/assume_role_credentials_provider.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
Correct - its a bug fix, a missed cherry pick when I put the original patch in. No breaking change. I've added a release note regardless. |
Member
|
ping @RyanTheOptimist |
Signed-off-by: Nigel Brittain <108375408+nbaws@users.noreply.github.com>
Member
|
/retest may need to wait on @RyanTheOptimist to be available |
mathetake
reviewed
Aug 12, 2025
mathetake
reviewed
Aug 12, 2025
test/extensions/common/aws/credential_providers/assume_role_credentials_provider_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/common/aws/credential_providers/assume_role_credentials_provider_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/common/aws/credential_providers/assume_role_credentials_provider_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/common/aws/credential_providers/assume_role_credentials_provider_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
…aws/envoy into assumerole_missing_parameters Signed-off-by: Nigel Brittain <nbaws@amazon.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
mattklein123
approved these changes
Aug 21, 2025
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
Commit Message: aws: assumerole missing protobuf validations Additional Description: Adds missing protobuf validations that were unintentionally skipped, plus test cases to match Risk Level: Low Testing: Unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Nigel Brittain <nbaws@amazon.com> Signed-off-by: Nigel Brittain <108375408+nbaws@users.noreply.github.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
Commit Message: aws: assumerole missing protobuf validations Additional Description: Adds missing protobuf validations that were unintentionally skipped, plus test cases to match Risk Level: Low Testing: Unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Nigel Brittain <nbaws@amazon.com> Signed-off-by: Nigel Brittain <108375408+nbaws@users.noreply.github.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
wtzhang23
pushed a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
Commit Message: aws: assumerole missing protobuf validations Additional Description: Adds missing protobuf validations that were unintentionally skipped, plus test cases to match Risk Level: Low Testing: Unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Nigel Brittain <nbaws@amazon.com> Signed-off-by: Nigel Brittain <108375408+nbaws@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: aws: assumerole missing protobuf validations
Additional Description: Adds missing protobuf validations that were unintentionally skipped, plus test cases to match
Risk Level: Low
Testing: Unit
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]