ext_proc: add failure_mode_allow per route override#40014
Merged
yanavlasov merged 12 commits intoenvoyproxy:mainfrom Jun 27, 2025
Merged
ext_proc: add failure_mode_allow per route override#40014yanavlasov merged 12 commits intoenvoyproxy:mainfrom
failure_mode_allow per route override#40014yanavlasov merged 12 commits intoenvoyproxy:mainfrom
Conversation
This commit was authored by jules.google (AI agent) with review by Andres Guedez. This commit adds a new `failure_mode_allow` field to the `ExtProcOverrides` message in the ExternalProcessor proto. This allows per-route configuration to override the default `failure_mode_allow` behavior of the ext_proc filter. The implementation follows the existing pattern for other overrides in ext_proc.cc, where the FilterConfigPerRoute constructor checks the override when initializing fields, and the Filter::mergePerRouteConfig method applies the override to the filter's effective configuration. Signed-off-by: Andres Guedez <aguedez@google.com>
This commit was authored by jules.google (AI agent) with review by Andres Guedez. This commit adds unit tests to verify the behavior of the `failure_mode_allow` override in the `ExtProcPerRoute` configuration. The tests cover scenarios where: - Filter-level `failure_mode_allow` is true, route override is false. - Filter-level `failure_mode_allow` is false, route override is true. - No route override is present, filter-level setting is used. - Route is disabled, `failure_mode_allow` override is ignored. Signed-off-by: Andres Guedez <aguedez@google.com> Signed-off-by: Andres Guedez <aguedez@google.com>
This commit was authored by jules.google (AI agent) with review by Andres Guedez. Removes the `has_failure_mode_allow()` check for the boolean field `failure_mode_allow` in `ExtProcOverrides` as scalar fields do not have `has_<field>()` methods in Protobuf. The presence of the override is determined by `config.has_overrides()`. This resolves a build error. Signed-off-by: Andres Guedez <aguedez@google.com> Signed-off-by: Andres Guedez <aguedez@google.com>
Signed-off-by: Andres Guedez <aguedez@google.com>
Signed-off-by: Andres Guedez <aguedez@google.com>
Signed-off-by: Andres Guedez <aguedez@google.com>
… logic. Signed-off-by: Andres Guedez <aguedez@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Andres Guedez <aguedez@google.com>
markdroth
reviewed
Jun 26, 2025
…otobuf.BoolValue to properly incorporate presence checks. Signed-off-by: Andres Guedez <aguedez@google.com>
Contributor
|
/lgtm api |
…or refactoring of EXPECT_* argument ordering for consistency. Signed-off-by: Andres Guedez <aguedez@google.com>
tyxia
previously approved these changes
Jun 27, 2025
Member
tyxia
left a comment
There was a problem hiding this comment.
LGTM, thanks
Sorry i missed it in the first pass. Please follow-up with a changelog change as this PR adds a new feature. Example: https://github.com/envoyproxy/envoy/pull/36279/files#diff-6f9c718224c533c13c2c0ba1d5abaab86be9d0cc73808749c77934e9f9b0d5d0
Contributor
|
@AndresGuedez please add release noted as Tianyu suggests. /wait |
Signed-off-by: Andres Guedez <aguedez@google.com>
Contributor
Author
Added changelog entry. Thanks! |
Signed-off-by: Andres Guedez <aguedez@google.com>
yanavlasov
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add
failure_mode_allowper route override to the ExtProc filter.Additional Description:
Risk Level: Low
Testing: Added ext_proc unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A