api: removes 'wip' from dynamic_modules#38956
Merged
wbpcode merged 3 commits intoenvoyproxy:mainfrom Mar 31, 2025
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
Author
|
oh sorry format |
11 tasks
wbpcode
approved these changes
Mar 31, 2025
Member
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this change. Happy to see dynamic module become more and more mature.
mathetake
added a commit
to envoyproxy/dynamic-modules-examples
that referenced
this pull request
Mar 31, 2025
The API is now not WIP! envoyproxy/envoy#38956 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
Commit Message: api: removes 'wip' from dynamic_modules Additional Description: The dynamic modules API was introduced 6 months ago in envoyproxy#36448 and at the time we didn't have either an implementation or confidence on the configuration API, so it has been marked WIP just in case. Now that the initial implementation is done, and the documentation as well as the example repository is hosted at envoyproxy/dynamic-modules-examples, early adopters have already tried it out and we haven't heard any concern about the configuration API, so this commit removes the WIP marker towards the next release of Envoy v1.34. Note that the extension itself is still in alpha, it follows the same caveat like any other alpha extensions. Risk Level: low Testing: existing tests. Docs Changes: Already done in the past commits Release Notes: Already done in the past commits Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
Commit Message: api: removes 'wip' from dynamic_modules Additional Description: The dynamic modules API was introduced 6 months ago in envoyproxy#36448 and at the time we didn't have either an implementation or confidence on the configuration API, so it has been marked WIP just in case. Now that the initial implementation is done, and the documentation as well as the example repository is hosted at envoyproxy/dynamic-modules-examples, early adopters have already tried it out and we haven't heard any concern about the configuration API, so this commit removes the WIP marker towards the next release of Envoy v1.34. Note that the extension itself is still in alpha, it follows the same caveat like any other alpha extensions. Risk Level: low Testing: existing tests. Docs Changes: Already done in the past commits Release Notes: Already done in the past commits Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: api: removes 'wip' from dynamic_modules
Additional Description:
The dynamic modules API was introduced 6 months ago in #36448 and at the time we didn't have either an implementation or confidence on the configuration API, so it has been marked WIP just in case.
Now that the initial implementation is done, and the documentation as well as the example repository is hosted at envoyproxy/dynamic-modules-examples, early adopters have already tried it out and we haven't heard any concern about the configuration API, so this commit removes the WIP marker towards the next release of Envoy v1.34.
Note that the extension itself is still in alpha, it follows the same caveat like any other alpha extensions.
Risk Level: low
Testing: existing tests.
Docs Changes: Already done in the past commits
Release Notes: Already done in the past commits
Platform Specific Features: n/a