Tracing: Allow extract span context data from request headers and inject new span context into it#388
Merged
RomanDzhabarov merged 7 commits intomasterfrom Jan 30, 2017
Merged
Conversation
include/envoy/http/header_map.h
Outdated
| HEADER_FUNC(Upgrade) \ | ||
| HEADER_FUNC(UserAgent) | ||
| HEADER_FUNC(UserAgent) \ | ||
| HEADER_FUNC(OtSpanContext) |
source/common/http/headers.h
Outdated
| const LowerCaseString TransferEncoding{"transfer-encoding"}; | ||
| const LowerCaseString Upgrade{"upgrade"}; | ||
| const LowerCaseString UserAgent{"user-agent"}; | ||
| const LowerCaseString OtSpanContext{"x-ot-span-context"}; |
| class LightStepSpan : public Span { | ||
| public: | ||
| LightStepSpan(lightstep::Span& span); | ||
| LightStepSpan(lightstep::Span span); |
include/envoy/tracing/http_tracer.h
Outdated
| /** | ||
| * Inject span context into HTTP carrier. | ||
| */ | ||
| virtual void inject(Span* active_span, Http::HeaderMap& headers) PURE; |
Member
There was a problem hiding this comment.
I don't understand why this needs to exist here. You only ever call inject() right after you call startSpan(), so just do it all inside the startSpan() flow of calls.
Member
Author
There was a problem hiding this comment.
yeah, prob no compelling reason to extract that into separate method
| LightStepSpanPtr active_span; | ||
|
|
||
| // Extract downstream context from HTTP carrier. | ||
| const std::string parent_context = |
Member
There was a problem hiding this comment.
storing to variable here is not needed, just check if header exists, then pass c_str() directly to ParseFromString. (In the future it would be nice to avoid string conversion).
mattklein123
approved these changes
Jan 30, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Remove api_manager code. * remove transcoding_repoistories
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…trap zh-translation:docs/root/configuration/overview/bootstrap.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: taking in the tip of master Risk Level: low Testing: CI and local for iOS Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: taking in the tip of master Risk Level: low Testing: CI and local for iOS Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Ensure hover styling has same border-radius, so the buttons maintain the shape when hovering. Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.