add force_locality_direct_routing feature#38756
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Apr 8, 2025
Merged
Conversation
|
Hi @jukie, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
5ce2826 to
cc9459e
Compare
arkodg
reviewed
Mar 15, 2025
Contributor
Author
|
/retest |
wbpcode
requested changes
Mar 15, 2025
Member
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for this contribution. Please add some more comment about the background and context to ensure it's acceptable for the community. Thanks again.
9f90a14 to
b564842
Compare
Contributor
Author
|
/retest |
wbpcode
previously approved these changes
Mar 22, 2025
Member
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for this great contribution. This make sense and actually make thing simpler. could you add some tests for this new feature? Thanks again.
/lgtm api
dc88d45 to
79cabec
Compare
Member
|
/wait on ci |
ee0c55d to
ae7a797
Compare
ae7a797 to
e0424da
Compare
1bb63e4 to
b321ffe
Compare
454a69f to
ccaf7bf
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
ccaf7bf to
0a2d55a
Compare
This was referenced Apr 9, 2025
wbpcode
pushed a commit
that referenced
this pull request
Apr 30, 2025
…#39058) <!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> Commit Message: Add force_local_zone to zone-aware routing with min_size option and deprecate force_locality_direct_routing. Additional Description: Follow-up to #38756. Adds minimum zone size parameter as a gate to forcing LocalityDirect mode in zone-aware-routing and renames force_locality_direct_routing to force_local_zone. Risk Level: Testing: Docs Changes: Yes Release Notes: Platform Specific Features: Fixes #38561 --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: Jukie <10012479+Jukie@users.noreply.github.com>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Jul 2, 2025
… (#39058) <!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> Commit Message: Add force_local_zone to zone-aware routing with min_size option and deprecate force_locality_direct_routing. Additional Description: Follow-up to envoyproxy/envoy#38756. Adds minimum zone size parameter as a gate to forcing LocalityDirect mode in zone-aware-routing and renames force_locality_direct_routing to force_local_zone. Risk Level: Testing: Docs Changes: Yes Release Notes: Platform Specific Features: Fixes #38561 --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: Jukie <10012479+Jukie@users.noreply.github.com> Mirrored from https://github.com/envoyproxy/envoy @ 88490aacd429b9d1c8a9d6c47376d1338c18fe31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: zone aware routing: add force_direct_routing
Additional Description: Allow forcing LocalityDirect routing mode for Zone Aware LB Config
Risk Level:
Testing:
Docs Changes: yes
Release Notes:
Platform Specific Features:
Fixes #38758