Use posix_memalign/free in AlignedAllocator for ANDROID_API<28.#38735
Merged
RyanTheOptimist merged 2 commits intoenvoyproxy:mainfrom Mar 13, 2025
Merged
Use posix_memalign/free in AlignedAllocator for ANDROID_API<28.#38735RyanTheOptimist merged 2 commits intoenvoyproxy:mainfrom
RyanTheOptimist merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Bin Wu <wub@google.com>
Contributor
Author
|
/assign @abeyad |
Contributor
Author
|
/retest |
abeyad
reviewed
Mar 13, 2025
| #pragma once | ||
|
|
||
| #ifdef __ANDROID_API__ | ||
| #if __ANDROID_API__ < 28 |
Contributor
There was a problem hiding this comment.
nit: I think we can combine these conditions to:
if defined(__ANDROID_API__) && __ANDROID_API__ < 28
Signed-off-by: Bin Wu <wub@google.com>
RyanTheOptimist
approved these changes
Mar 13, 2025
Contributor
Author
|
/retest |
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
…yproxy#38735) std::aligned_alloc is not available for ANDROID_API<28, this change switch it to posix_memalign/free instead. Commit Message: Use posix_memalign/free in AlignedAllocator for ANDROID_API<28. Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Bin Wu <wub@google.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…yproxy#38735) std::aligned_alloc is not available for ANDROID_API<28, this change switch it to posix_memalign/free instead. Commit Message: Use posix_memalign/free in AlignedAllocator for ANDROID_API<28. Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Bin Wu <wub@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::aligned_alloc is not available for ANDROID_API<28, this change switch it to posix_memalign/free instead.
Commit Message: Use posix_memalign/free in AlignedAllocator for ANDROID_API<28.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]