ci: Add trigger for Android and iOS CI jobs on source/common changes#38733
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Mar 14, 2025
Merged
ci: Add trigger for Android and iOS CI jobs on source/common changes#38733phlax merged 2 commits intoenvoyproxy:mainfrom
phlax merged 2 commits intoenvoyproxy:mainfrom
Conversation
There have been several instances that changes, particularily to source/* directories, have introduced C++ features not supported by the Android NDK or iOS XCode version for Envoy Mobile. Without triggering the mobile Android and iOS jobs on those changes, we don't catch them until after the fact. The latest example is the std::aligned_alloc PR: envoyproxy#38707. Which introduced build errors on Android that CI didn't catch at the time of the PR and only in a subsequent PR that triggered mobile CI: https://github.com/envoyproxy/envoy/actions/runs/13818727995/job/38658598098. This change causes any changes to `source/common/` to trigger Android and iOS CI. This is a start in allowing us to catch such changes in the PR making the changes. Signed-off-by: Ali Beyad <abeyad@google.com>
Contributor
Author
|
/assign @phlax |
Contributor
Author
|
@phlax what do you think? |
Member
|
probably a good idea - iirc we held off doing this previously for fear of the ci cost - but the issue comes up from time to time |
Contributor
Author
We can start off with just doing this for |
Contributor
Author
|
/retest |
Contributor
Author
|
@phlax is this good to merge? |
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
…nvoyproxy#38733) There have been several instances that changes, particularily to source/* directories, have introduced C++ features not supported by the Android NDK or iOS XCode version for Envoy Mobile. Without triggering the mobile Android and iOS jobs on those changes, we don't catch them until after the fact. The latest example is the std::aligned_alloc PR: envoyproxy#38707. Which introduced build errors on Android that CI didn't catch at the time of the PR and only in a subsequent PR that triggered mobile CI: https://github.com/envoyproxy/envoy/actions/runs/13818727995/job/38658598098. This change causes any changes to `source/common/` to trigger Android and iOS CI. This is a start in allowing us to catch such changes in the PR making the changes. Signed-off-by: Ali Beyad <abeyad@google.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…nvoyproxy#38733) There have been several instances that changes, particularily to source/* directories, have introduced C++ features not supported by the Android NDK or iOS XCode version for Envoy Mobile. Without triggering the mobile Android and iOS jobs on those changes, we don't catch them until after the fact. The latest example is the std::aligned_alloc PR: envoyproxy#38707. Which introduced build errors on Android that CI didn't catch at the time of the PR and only in a subsequent PR that triggered mobile CI: https://github.com/envoyproxy/envoy/actions/runs/13818727995/job/38658598098. This change causes any changes to `source/common/` to trigger Android and iOS CI. This is a start in allowing us to catch such changes in the PR making the changes. Signed-off-by: Ali Beyad <abeyad@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been several instances that changes, particularily to source/* directories, have introduced C++ features not supported by the Android NDK or iOS XCode version for Envoy Mobile. Without triggering the mobile Android and iOS jobs on those changes, we don't catch them until after the fact.
The latest example is the std::aligned_alloc PR: #38707.
Which introduced build errors on Android that CI didn't catch at the time of the PR and only in a subsequent PR that triggered mobile CI: https://github.com/envoyproxy/envoy/actions/runs/13818727995/job/38658598098.
This change causes any changes to
source/common/to trigger Android and iOS CI. This is a start in allowing us to catch such changes in the PR making the changes.