dynamic_modules: make dynamic module filter a dual filter#38686
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Mar 18, 2025
Merged
dynamic_modules: make dynamic module filter a dual filter#38686mattklein123 merged 4 commits intoenvoyproxy:mainfrom
mattklein123 merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
11 tasks
mathetake
reviewed
Mar 10, 2025
| runHeaderCallbacksTest(true); | ||
| } | ||
|
|
||
| TEST_P(DynamicModulesIntegrationTest, UpstreamFilter) { |
Member
There was a problem hiding this comment.
how does this test differ from the above TEST_P(DynamicModulesIntegrationTest, HeaderCallbacks) { runHeaderCallbacksTest(false); } ? would it be possible to delete this one?
Contributor
Author
There was a problem hiding this comment.
yeah, forgot to cleanup. Removed. Thanks!
Contributor
|
/assign @mattklein123 |
mattklein123
approved these changes
Mar 18, 2025
mathetake
added a commit
to envoyproxy/dynamic-modules-examples
that referenced
this pull request
Mar 18, 2025
Thanks to the work by @vikaschoudhary16 in envoyproxy/envoy#38686 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
…#38686) Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…#38686) Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38448
Commit Message: dynamic_modules: make dynamic module filter a dual filter
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]